From 5b214bbaf423b60cde25f6b46c1e16225d71f07f Mon Sep 17 00:00:00 2001 From: pierrezimmermann Date: Sun, 20 Nov 2022 09:47:56 +0100 Subject: [PATCH 01/45] BREAKING CHANGE : make placeholdertext queries return host elements --- src/__tests__/config.test.ts | 4 ++ src/config.ts | 4 ++ .../__tests__/placeholderText.test.tsx | 44 ++++++++++++++++++- src/queries/options.ts | 13 ++++++ src/queries/placeholderText.ts | 17 +++++-- typings/index.flow.js | 10 ++++- website/docs/API.md | 5 +++ website/docs/Queries.md | 3 +- 8 files changed, 93 insertions(+), 7 deletions(-) diff --git a/src/__tests__/config.test.ts b/src/__tests__/config.test.ts index c197b9c3a..e32ec2b5b 100644 --- a/src/__tests__/config.test.ts +++ b/src/__tests__/config.test.ts @@ -23,6 +23,7 @@ test('configure() overrides existing config values', () => { defaultDebugOptions: { message: 'debug message' }, defaultIncludeHiddenElements: true, useBreakingChanges: false, + useLegacyQueries: false, }); }); @@ -30,13 +31,16 @@ test('resetToDefaults() resets config to defaults', () => { configure({ asyncUtilTimeout: 5000, defaultIncludeHiddenElements: false, + useLegacyQueries: true, }); expect(getConfig().asyncUtilTimeout).toEqual(5000); expect(getConfig().defaultIncludeHiddenElements).toEqual(false); + expect(getConfig().useLegacyQueries).toBe(true); resetToDefaults(); expect(getConfig().asyncUtilTimeout).toEqual(1000); expect(getConfig().defaultIncludeHiddenElements).toEqual(true); + expect(getConfig().useLegacyQueries).toBe(false); }); test('resetToDefaults() resets internal config to defaults', () => { diff --git a/src/config.ts b/src/config.ts index 64de13d13..26c404336 100644 --- a/src/config.ts +++ b/src/config.ts @@ -12,6 +12,9 @@ export type Config = { /** Default options for `debug` helper. */ defaultDebugOptions?: Partial; + + /** Option to return composite components */ + useLegacyQueries: boolean; }; export type ConfigAliasOptions = { @@ -28,6 +31,7 @@ const defaultConfig: InternalConfig = { useBreakingChanges: false, asyncUtilTimeout: 1000, defaultIncludeHiddenElements: true, + useLegacyQueries: false, }; let config = { ...defaultConfig }; diff --git a/src/queries/__tests__/placeholderText.test.tsx b/src/queries/__tests__/placeholderText.test.tsx index ef75bfe36..f2b99f993 100644 --- a/src/queries/__tests__/placeholderText.test.tsx +++ b/src/queries/__tests__/placeholderText.test.tsx @@ -1,6 +1,6 @@ import * as React from 'react'; import { View, TextInput } from 'react-native'; -import { render } from '../..'; +import { render, configure, resetToDefaults } from '../..'; const PLACEHOLDER_FRESHNESS = 'Add custom freshness'; const PLACEHOLDER_CHEF = 'Who inspected freshness?'; @@ -8,6 +8,10 @@ const INPUT_FRESHNESS = 'Custom Freshie'; const INPUT_CHEF = 'I inspected freshie'; const DEFAULT_INPUT_CHEF = 'What did you inspect?'; +beforeEach(() => { + resetToDefaults(); +}); + const Banana = () => (