Skip to content

debug documentation incorrect about returned JSX or misconfiguration? #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tschanz-pcv opened this issue Jul 22, 2020 · 2 comments
Closed
Labels
docs good first issue Good for newcomers

Comments

@tschanz-pcv
Copy link

Is the Debug documentation wrong about the returned JSX or have I mis-configured by setup?

According to the docs about the debug function it would suggest that a component which contains <TouchableOpacity> would render this as-is and not expand it into <View>s.

But the Snapshot and debug output clearly expands all components into <View>s.

Is the documentation wrong or is this configurable?

There is another issue related to this: #156

@tschanz-pcv tschanz-pcv added the question Further information is requested label Jul 22, 2020
@thymikee
Copy link
Member

It's possible that the mock of TouchableOpacity changed since this doc was made. Feel free to send an updated one, based on the results of running something similar with the latest version of React Native. IIRC it is indeed implemented using native Views so whatever comes out of the snapshot is correct.

@thymikee thymikee added docs good first issue Good for newcomers and removed question Further information is requested labels Jul 22, 2020
@thymikee
Copy link
Member

thymikee commented Sep 3, 2020

This has been addressed recently, thanks for catching this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants