[SOL] Adjust SBF customization after upgrading to rust 1.68.0

Author: dmakarov

.github/workflows/ci.yml

@@ -92,6 +92,7 @@ jobs:
             os: ubuntu-20.04-16core-64gb
             env: {}
           - name: sbf-solana-solana
+            tidy: false
             os: ubuntu-latest
             env: {}
           - name: x86_64-gnu-tools
@@ -288,6 +289,9 @@ jobs:
       - name: install sccache
         run: src/ci/scripts/install-sccache.sh
         if: success() && !env.SKIP_JOB
+      - name: select Xcode
+        run: src/ci/scripts/select-xcode.sh
+        if: success() && !env.SKIP_JOB
       - name: install clang
         run: src/ci/scripts/install-clang.sh
         if: success() && !env.SKIP_JOB

compiler/rustc_target/src/spec/sbf_base.rs

@@ -1,5 +1,5 @@
 use crate::abi::Endian;
-use super::{cvs, LinkArgs, LinkerFlavor, PanicStrategy, TargetOptions, LldFlavor};
+use super::{Cc, cvs, LinkerFlavor, Lld, PanicStrategy, TargetOptions};
 
 pub fn opts() -> TargetOptions {
     let linker_script = r"
@@ -28,13 +28,10 @@ SECTIONS
     }
 }
 ";
-    let mut lld_args = Vec::new();
-    lld_args.push("--threads=1".into());
-    lld_args.push("-z".into());
-    lld_args.push("notext".into());
-    let mut pre_link_args = LinkArgs::new();
-    pre_link_args.insert(LinkerFlavor::Ld, lld_args.clone());
-    pre_link_args.insert(LinkerFlavor::Lld(LldFlavor::Ld), lld_args);
+    let pre_link_args = TargetOptions::link_args(
+        LinkerFlavor::Gnu(Cc::No, Lld::No),
+        &["--threads=1", "-z", "notext"],
+    );
 
     TargetOptions {
         allow_asm: true,
@@ -50,8 +47,7 @@ SECTIONS
         families: cvs!["solana"],
         link_script: Some(linker_script.into()),
         linker: Some("rust-lld".into()),
-        linker_flavor: LinkerFlavor::Lld(LldFlavor::Ld),
-        linker_is_gnu: true,
+        linker_flavor: LinkerFlavor::Gnu(Cc::No, Lld::Yes),
         main_needs_argc_argv: false,
         max_atomic_width: Some(64),
         no_default_libraries: true,

config.toml

@@ -108,6 +108,8 @@ link-shared = false
 # Which LLVM projects to build along with the LLVM base libraries/tools
 enable-projects = "clang;lld"
 
+download-ci-llvm = false
+
 # =============================================================================
 # General build configuration options
 # =============================================================================

library/core/tests/slice.rs

@@ -1809,9 +1809,9 @@ fn select_nth_unstable() {
     use rand::Rng;
     use rand::seq::SliceRandom;
 
-    let mut rng = StdRng::seed_from_u64(0);
+    let mut rng = crate::test_rng();
 
-    for len in (2..21).chain(200..201) {
+    for len in (2..21).chain(500..501) {
         let mut orig = vec![0; len];
 
         for &modulus in &[5, 10, 1000] {

library/std/Cargo.toml

@@ -32,7 +32,7 @@ std_detect = { path = "../stdarch/crates/std_detect", default-features = false,
 ] }
 
 # Dependencies of the `backtrace` crate
-[target.'cfg(all(not(target_arch = "bpf"), not(target_arch = "sbf")))'.dependencies]
+[target.'cfg(not(target_family = "solana"))'.dependencies]
 addr2line = { version = "0.22.0", optional = true, default-features = false }
 rustc-demangle = { version = "0.1.24", features = ['rustc-dep-of-std'] }
 

library/std/src/error.rs

@@ -4,14 +4,15 @@
 #[cfg(test)]
 mod tests;
 
+#[cfg(not(target_family = "solana"))]
+use crate::backtrace::Backtrace;
+use crate::fmt::{self, Write};
+
 #[stable(feature = "rust1", since = "1.0.0")]
 pub use core::error::Error;
 #[unstable(feature = "error_generic_member_access", issue = "99301")]
 pub use core::error::{Request, request_ref, request_value};
 
-use crate::backtrace::Backtrace;
-use crate::fmt::{self, Write};
-
 /// An error reporter that prints an error and its sources.
 ///
 /// Report also exposes configuration options for formatting the error sources, either entirely on a
@@ -449,6 +450,7 @@ impl<E> Report<E>
 where
     E: Error,
 {
+    #[cfg(not(target_family = "solana"))]
     fn backtrace(&self) -> Option<&Backtrace> {
         // have to grab the backtrace on the first error directly since that error may not be
         // 'static
@@ -499,6 +501,7 @@ where
             }
         }
 
+        #[cfg(not(target_family = "solana"))]
         if self.show_backtrace {
             if let Some(backtrace) = self.backtrace() {
                 write!(f, "\n\nStack backtrace:\n{}", backtrace.to_string().trim_end())?;

library/std/src/io/mod.rs

@@ -307,9 +307,10 @@ pub(crate) use error::const_io_error;
 pub use self::buffered::WriterPanicked;
 #[unstable(feature = "raw_os_error_ty", issue = "107792")]
 pub use self::error::RawOsError;
+#[cfg(not(target_family = "solana"))]
+pub(crate) use self::stdio::attempt_print_to_stderr;
 #[stable(feature = "is_terminal", since = "1.70.0")]
 pub use self::stdio::IsTerminal;
-pub(crate) use self::stdio::attempt_print_to_stderr;
 #[unstable(feature = "print_internals", issue = "none")]
 #[doc(hidden)]
 pub use self::stdio::{_eprint, _print};

library/std/src/io/stdio.rs

@@ -3,14 +3,15 @@
 #[cfg(test)]
 mod tests;
 
-use crate::fmt;
-use crate::fs::File;
 use crate::io::prelude::*;
 
 #[cfg(not(target_family = "solana"))]
 use crate::sync::{ReentrantLock, ReentrantLockGuard};
 #[cfg(not(target_family = "solana"))]
 use crate::cell::{Cell, RefCell};
+use crate::fmt;
+#[cfg(not(target_family = "solana"))]
+use crate::fs::File;
 #[cfg(not(target_os = "solana"))]
 use crate::io::{
     self, BorrowedCursor, BufReader, IoSlice, IoSliceMut, LineWriter, Lines, 
@@ -1346,6 +1347,7 @@ where
     }
 }
 
+#[cfg(not(target_family = "solana"))]
 fn print_to_buffer_if_capture_used(args: fmt::Arguments<'_>) -> bool {
     OUTPUT_CAPTURE_USED.load(Ordering::Relaxed)
         && OUTPUT_CAPTURE.try_with(|s| {
@@ -1362,6 +1364,7 @@ fn print_to_buffer_if_capture_used(args: fmt::Arguments<'_>) -> bool {
 /// Used by impl Termination for Result to print error after `main` or a test
 /// has returned. Should avoid panicking, although we can't help it if one of
 /// the Display impls inside args decides to.
+#[cfg(not(target_family = "solana"))]
 pub(crate) fn attempt_print_to_stderr(args: fmt::Arguments<'_>) {
     if print_to_buffer_if_capture_used(args) {
         return;
@@ -1426,6 +1429,7 @@ pub trait IsTerminal: crate::sealed::Sealed {
     fn is_terminal(&self) -> bool;
 }
 
+#[cfg(not(target_family = "solana"))]
 macro_rules! impl_is_terminal {
     ($($t:ty),*$(,)?) => {$(
         #[unstable(feature = "sealed", issue = "none")]
@@ -1441,6 +1445,7 @@ macro_rules! impl_is_terminal {
     )*}
 }
 
+#[cfg(not(target_family = "solana"))]
 impl_is_terminal!(File, Stdin, StdinLock<'_>, Stdout, StdoutLock<'_>, Stderr, StderrLock<'_>);
 
 #[unstable(

library/std/src/panicking.rs

@@ -30,8 +30,9 @@ use crate::mem;
 use crate::process;
 #[cfg(not(target_family = "solana"))]
 use crate::sync::atomic::{AtomicBool, Ordering};
+#[cfg(not(target_family = "solana"))]
 use crate::sync::{PoisonError, RwLock};
-#[cfg(not(target_os = "solana"))]
+#[cfg(not(target_family = "solana"))]
 use crate::sys::stdio::panic_output;
 #[cfg(not(target_family = "solana"))]
 use crate::sys::backtrace;
@@ -77,7 +78,7 @@ extern "C" fn __rust_foreign_exception() -> ! {
     rtabort!("Rust cannot catch foreign exceptions");
 }
 
-#[cfg(not(target_os = "solana"))]
+#[cfg(not(target_family = "solana"))]
 enum Hook {
     Default,
     Custom(Box<dyn Fn(&PanicHookInfo<'_>) + 'static + Sync + Send>),
@@ -94,15 +95,15 @@ impl Hook {
     }
 }
 
-#[cfg(not(target_os = "solana"))]
+#[cfg(not(target_family = "solana"))]
 impl Default for Hook {
     #[inline]
     fn default() -> Hook {
         Hook::Default
     }
 }
 
-#[cfg(not(target_os = "solana"))]
+#[cfg(not(target_family = "solana"))]
 static HOOK: RwLock<Hook> = RwLock::new(Hook::Default);
 
 /// Registers a custom panic hook, replacing the previously registered hook.
@@ -442,7 +443,7 @@ pub mod panic_count {
     //
     // This also updates thread-local state to keep track of whether a panic
     // hook is currently executing.
-    #[cfg(not(target_os = "solana"))]
+    #[cfg(not(target_family = "solana"))]
     pub fn increase(run_panic_hook: bool) -> Option<MustAbort> {
         let global_count = GLOBAL_PANIC_COUNT.fetch_add(1, Ordering::Relaxed);
         if global_count & ALWAYS_ABORT_FLAG != 0 {
@@ -510,7 +511,7 @@ pub mod panic_count {
 
     // Slow path is in a separate function to reduce the amount of code
     // inlined from `count_is_zero`.
-    #[cfg(not(target_os = "solana"))]
+    #[cfg(not(target_family = "solana"))]
     #[inline(never)]
     #[cold]
     fn is_zero_slow_path() -> bool {

library/std/src/process.rs

@@ -2452,10 +2452,15 @@ impl<T: Termination, E: fmt::Debug> Termination for Result<T, E> {
     fn report(self) -> ExitCode {
         match self {
             Ok(val) => val.report(),
+            #[cfg(not(target_family = "solana"))]
             Err(err) => {
                 io::attempt_print_to_stderr(format_args_nl!("Error: {err:?}"));
                 ExitCode::FAILURE
             }
+            #[cfg(target_family = "solana")]
+            Err(_err) => {
+                ExitCode::FAILURE
+            }
         }
     }
 }

library/std/src/rt.rs

@@ -215,6 +215,7 @@ fn lang_start<T: crate::process::Termination + 'static>(
     main: fn() -> T,
     _argc: isize,
     _argv: *const *const u8,
+    _sigpipe: u8,
 ) -> isize {
     main().report().to_i32() as isize
 }

library/std/src/sync/mpmc/utils.rs

@@ -3,6 +3,7 @@ use crate::ops::{Deref, DerefMut};
 
 /// Pads and aligns a value to the length of a cache line.
 #[derive(Clone, Copy, Default, Hash, PartialEq, Eq)]
+#[cfg_attr(target_family = "solana", repr(align(8)))]
 // Starting from Intel's Sandy Bridge, spatial prefetcher is now pulling pairs of 64-byte cache
 // lines at a time, so we have to align to 128 bytes rather than 64.
 //
@@ -66,6 +67,7 @@ use crate::ops::{Deref, DerefMut};
         target_arch = "mips64r6",
         target_arch = "riscv64",
         target_arch = "s390x",
+        target_family = "solana",
     )),
     repr(align(64))
 )]

library/std/src/sys/sbf/futex.rs

@@ -0,0 +1,14 @@
+use crate::sync::atomic::AtomicU32;
+use crate::time::Duration;
+
+pub fn futex_wait(_futex: &AtomicU32, _expected: u32, _timeout: Option<Duration>) -> bool {
+    false
+}
+
+#[inline]
+pub fn futex_wake(_futex: &AtomicU32) -> bool {
+    false
+}
+
+#[inline]
+pub fn futex_wake_all(_futex: &AtomicU32) {}

library/std/src/sys/sbf/mod.rs

@@ -20,6 +20,7 @@ pub mod args;
 pub mod cmath;
 pub mod env;
 pub mod fs;
+pub mod futex;
 pub mod io;
 pub mod memchr;
 pub mod net;
@@ -34,16 +35,17 @@ pub mod time;
 #[path = "../unix/os_str.rs"]
 pub mod os_str;
 
-pub mod condvar;
-pub mod mutex;
-pub mod rwlock;
 pub mod thread_local_dtor;
 pub mod thread_local_key;
 
+#[path = "../unix/locks"]
 pub mod locks {
-    pub use super::condvar::*;
-    pub use super::mutex::*;
-    pub use super::rwlock::*;
+    mod futex_condvar;
+    mod futex_mutex;
+    mod futex_rwlock;
+    pub(crate) use futex_condvar::Condvar;
+    pub(crate) use futex_mutex::Mutex;
+    pub(crate) use futex_rwlock::RwLock;
 }
 
 #[cfg(not(target_feature = "static-syscalls"))]

library/std/src/sys/sbf/pipe.rs

@@ -18,6 +18,10 @@ impl AnonPipe {
         false
     }
 
+    pub fn read_to_end(&self, _buf: &mut Vec<u8>) -> io::Result<usize> {
+        match self.0 {}
+    }
+
     pub fn write(&self, _buf: &[u8]) -> io::Result<usize> {
         match self.0 {}
     }

library/std/src/sys/sbf/process.rs

@@ -65,6 +65,10 @@ impl Command {
         unsupported()
     }
 
+    pub fn output(&mut self) -> io::Result<(ExitStatus, Vec<u8>, Vec<u8>)> {
+        unsupported()
+    }
+
     pub fn get_args(&self) -> CommandArgs<'_> {
         let mut iter = self.args.iter();
         iter.next();

library/std/src/sys/sbf/thread_local_key.rs

@@ -1,3 +1,4 @@
+#![allow(fuzzy_provenance_casts)]
 use crate::boxed::Box;
 use crate::ptr;
 
@@ -33,8 +34,3 @@ pub unsafe fn destroy(key: Key) {
         f(key.value);
     }
 }
-
-#[inline]
-pub fn requires_synchronized_create() -> bool {
-    false
-}

library/std/src/sys/sync/once/mod.rs

@@ -18,6 +18,7 @@ cfg_if::cfg_if! {
         target_os = "dragonfly",
         target_os = "fuchsia",
         target_os = "hermit",
+        target_os = "solana",
     ))] {
         mod futex;
         pub use futex::{Once, OnceState};

library/std/src/thread/mod.rs

@@ -1259,7 +1259,7 @@ impl ThreadId {
                         Err(id) => last = id,
                     }
                 }
-            } else if #[cfg(not(target_os = "solana"))] {
+            } else if #[cfg(not(target_family = "solana"))] {
                 use crate::sync::{Mutex, PoisonError};
 
                 static COUNTER: Mutex<u64> = Mutex::new(0);