fix sveltejs#2086: detach error when node is not attached to DOM

btakita · btakita · commit c259e580dbf0 · 2019-07-02T15:02:37.000-04:00
diff --git a/src/runtime/internal/dom.ts b/src/runtime/internal/dom.ts
@@ -7,7 +7,9 @@ export function insert(target: Node, node: Node, anchor?: Node) {
 }
 
 export function detach(node: Node) {
-	node.parentNode.removeChild(node);
+	if (node.parentNode) {
+		node.parentNode.removeChild(node);
+	}
 }
 
 export function detach_between(before: Node, after: Node) {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,9 @@ export function insert(target: Node, node: Node, anchor?: Node) {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`export function detach(node: Node) {`
`10`		`- node.parentNode.removeChild(node);`
	`10`	`+ if (node.parentNode) {`
	`11`	`+ node.parentNode.removeChild(node);`
	`12`	`+ }`
`11`	`13`	`}`
`12`	`14`
`13`	`15`	`export function detach_between(before: Node, after: Node) {`