-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add ESM support #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would be happy to open a pull request but wish to confirm interest from the maintainers first. |
Please do. Or fork the project. |
yea submit a pr I'd love to take a look at it |
What is the status of this one? |
I'm currently not able to sit down and do this, but if someone else wanted to that would be great. |
I switched over to https://github.com/panates/postgresql-client for ESM & TS support. So far no problems. |
+1 |
When
import
ing a CommonJS library, it's flattened into a single object, and you're unable to take advantage of any ESM features. However if you add a few lines to yourpackage.json
and aesm.mjs
wrapper file that simply re-exports the contents ofindex.js
, then ESM users will be able to take full advantage of ESM features without any changes needed to your source code, and without affecting any CommonJS users. Thepackage.json
changes would be as simple as:The
"index.js"
fallback is only necessary to avoidpackage.json
parsing errors in some older versions of Node, which would affect CommonJS users as well. If this library ever supports only Node 14+ in the future, the fallback could be removed.The text was updated successfully, but these errors were encountered: