Skip to content

add docs for the default array type conversion? #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianstormtaylor opened this issue Sep 26, 2017 · 2 comments
Open

add docs for the default array type conversion? #1462

ianstormtaylor opened this issue Sep 26, 2017 · 2 comments
Milestone

Comments

@ianstormtaylor
Copy link

Thanks for a great library!

Looking through the issues, it seems like arrays are converted to Postgres arrays. But I wasn't able to find a clear answer to whether arrays of objects are converted to JSON arrays or Postgres arrays. Either way, whatever the answer ends up being could it be added to the type docs for future users?

@abenhamdine
Copy link
Contributor

abenhamdine commented Sep 27, 2017

Yes good idea to add to the docs, though it's seems more related to https://github.com/brianc/node-pg-types

See also closed PR #1432 (not merged) for more background.

@ianstormtaylor
Copy link
Author

Awesome, thanks @abenhamdine that PR explains it well, and the decision makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants