Merge pull request #5 from grncdr/no-row-description

Work with queries that don't have row descriptions

Author: brianc

index.js

@@ -32,16 +32,30 @@ Cursor.prototype.submit = function(connection) {
   }, true)
 
   con.flush()
+
+  con.once('noData', ifNoData)
+  con.once('rowDescription', function () {
+    con.removeListener('noData', ifNoData);
+  });
+
+  function ifNoData () {
+    self.state = 'idle'
+    self._shiftQueue();
+  }
 }
 
-Cursor.prototype.handleRowDescription = function(msg) {
-  this._result.addFields(msg.fields)
-  this.state = 'idle'
+Cursor.prototype._shiftQueue = function () {
   if(this._queue.length) {
     this._getRows.apply(this, this._queue.shift())
   }
 }
 
+Cursor.prototype.handleRowDescription = function(msg) {
+  this._result.addFields(msg.fields)
+  this.state = 'idle'
+  this._shiftQueue();
+}
+
 Cursor.prototype.handleDataRow = function(msg) {
   var row = this._result.parseRow(msg.fields)
   this._rows.push(row)
@@ -103,7 +117,7 @@ Cursor.prototype._getRows = function(rows, cb) {
 }
 
 Cursor.prototype.end = function(cb) {
-  if(this.statue != 'initialized') {
+  if(this.state != 'initialized') {
     this.connection.sync()
   }
   this.connection.end()

package.json

@@ -7,7 +7,7 @@
     "test": "test"
   },
   "scripts": {
-    "test": "node test/"
+    "test": "mocha test/"
   },
   "author": "Brian M. Carlson",
   "license": "MIT",

test/no-data-handling.js

@@ -0,0 +1,25 @@
+var assert = require('assert')
+var pg = require('pg.js');
+var Cursor = require('../');
+
+describe('queries with no data', function () {
+  beforeEach(function(done) {
+    var client = this.client = new pg.Client()
+    client.connect(done)
+  })
+
+
+  afterEach(function() {
+    this.client.end()
+  })
+
+  it('handles queries that return no data', function (done) {
+    var cursor = new Cursor('CREATE TEMPORARY TABLE whatwhat (thing int)')
+    this.client.query(cursor)
+    cursor.read(100, function (err, rows) {
+      assert.ifError(err)
+      assert.equal(rows.length, 0)
+      done()
+    })
+  });
+});