Skip to content

Commit 66ea024

Browse files
committed
add failing test for #130
1 parent dd84db3 commit 66ea024

File tree

4 files changed

+29
-8
lines changed

4 files changed

+29
-8
lines changed
-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
11
var helper = require(__dirname+'/../test-helper');
22

3-
//creates a client from cli parameters
4-
helper.client = function() {
5-
var client = new Client(helper.config);
6-
client.connect();
7-
return client;
8-
};
9-
103
module.exports = helper;

test/integration/gh-issues/130.js

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
var helper = require(__dirname + '/../test-helper');
2+
var exec = require('child_process').exec;
3+
4+
helper.pg.defaults.poolIdleTimeout = 1000;
5+
6+
helper.pg.connect(helper.config, function(err,client) {
7+
client.query("SELECT pg_backend_pid()", function(err, result) {
8+
var pid = result.rows[0].pg_backend_pid;
9+
exec('psql -c "select pg_terminate_backend('+pid+')" template1', assert.calls(function (error, stdout, stderr) {
10+
assert.isNull(error);
11+
}));
12+
});
13+
});
14+
15+
helper.pg.on('error', function(err, client) {
16+
//swallow errors
17+
});

test/integration/test-helper.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
11
var helper = require(__dirname + '/../test-helper');
22

3-
//TODO would this be better served set at ../test-helper?
43
if(helper.args.native) {
54
Client = require(__dirname + '/../../lib/native');
5+
helper.Client = Client;
66
helper.pg = helper.pg.native;
77
}
8+
9+
//creates a client from cli parameters
10+
helper.client = function() {
11+
var client = new Client(helper.config);
12+
client.connect();
13+
return client;
14+
};
15+
816
//export parent helper stuffs
917
module.exports = helper;
1018

test/unit/test-helper.js

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ MemoryStream = function() {
66
this.packets = [];
77
};
88

9+
910
helper.sys.inherits(MemoryStream, EventEmitter);
1011

1112
var p = MemoryStream.prototype;
@@ -14,6 +15,8 @@ p.write = function(packet) {
1415
this.packets.push(packet);
1516
};
1617

18+
p.writable = true;
19+
1720
createClient = function() {
1821
var stream = new MemoryStream();
1922
stream.readyState = "open";

0 commit comments

Comments
 (0)