(copy-from) fix 6.0.0 issue with node 14 (_destroy / _final race)

Author: jeromew

.travis.yml

@@ -12,6 +12,11 @@ jobs:
         postgresql: '9.6'
       env:
         - PGVERSION=9.6 PGUSER=postgres PGDATABASE=postgres
+    - node_js: '14'
+      addons:
+        postgresql: '9.6'
+      env:
+        - PGVERSION=9.6 PGUSER=postgres PGDATABASE=postgres
     - node_js: '10'
       addons:
         postgresql: '11'

copy-from.js

@@ -46,6 +46,7 @@ class CopyStreamQuery extends Writable {
     // send a CopyFail message that will rollback the COPY operation.
     // the cb will be called only after the ErrorResponse message is received
     // from the backend
+    if (this.cb_ReadyForQuery) return cb(err)
     this.cb_destroy = cb
     const msg = err ? err.message : 'NODE-PG-COPY-STREAMS destroy() was called'
     const self = this

package-lock.json

@@ -36,7 +36,7 @@
     "heroku-env": "~0.1.1",
     "lodash": "^4.17.19",
     "mocha": "^7.1.2",
-    "pg": "^7.8.2",
+    "pg": "^8.7.1",
     "prettier": "^2.0.5"
   },
   "prettier": {

package.json

@@ -328,18 +328,20 @@ describe('copy-from', () => {
         createCopyFromQuery('tablename', '(field1 int)', (client, copyFromStream) => {
           spyOnEmitCalls(copyFromStream)
           const pt = new PassThrough()
-          pipeline(pt, copyFromStream, (err) => {
+          copyFromStream.on('error', (err) => {
             assert.equal(copyFromStream.emits['error'].length, 1)
             const expectedMessage = /COPY from stdin failed/
             assert.notEqual(
               copyFromStream.emits['error'][0].toString().search(expectedMessage),
               -1,
               'Error message should mention that COPY failed'
             )
-            assert.ok(err)
             client.end()
             done()
           })
+          pipeline(pt, copyFromStream, (err) => {
+            assert.ok(err)
+          })
           pt.emit('error', new Error('pipelineError'))
         })
       })
@@ -348,18 +350,20 @@ describe('copy-from', () => {
         createCopyFromQuery('tablename', '(field1 int)', (client, copyFromStream) => {
           spyOnEmitCalls(copyFromStream)
           const pt = new PassThrough()
-          pipeline(pt, copyFromStream, (err) => {
+          copyFromStream.on('error', (err) => {
             assert.equal(copyFromStream.emits['error'].length, 1)
             const expectedMessage = /COPY from stdin failed/
             assert.notEqual(
               copyFromStream.emits['error'][0].toString().search(expectedMessage),
               -1,
               'Error message should mention that COPY failed'
             )
-            assert.ok(err)
             client.end()
             done()
           })
+          pipeline(pt, copyFromStream, (err) => {
+            assert.ok(err)
+          })
           client.connection.once('copyInResponse', () => {
             pt.emit('error', new Error('pipelineError'))
           })