Skip to content

Commit 23940a9

Browse files
mkarolincdesouza-chromium
authored andcommitted
[cr133][Devtools] custom implementation of lit/static-html was removed
Chromium change: https://source.chromium.org/chromium/_/chromium/devtools/devtools-frontend/+/8d94a72e2fad3764dd347ff6c755b5613caae03d commit 8d94a72e2fad3764dd347ff6c755b5613caae03d (origin/chromium/6934) Author: Benedikt Meurer <[email protected]> Date: Thu Jan 2 14:00:42 2025 +0100 [cleanup] Remove our custom implementation of `lit/static-html`. When we were using `litTagName` heavily, we rolled our own custom implementation of `lit/static-html`, which was optimized for the common case in our codebase. With the removal of `litTagName` we are left with only one place in the codebase where we use, and in this particular code path our optimization is useless (and even costs us more), since the `litTagName` changes in every loop iteration. Use the upstream `lit/static-html` module instead and remove our custom logic. This makes all regular calls to `html` faster in DevTools, since we no longer preprocess the template string looking for potential static parts. Drive-by-fix: Fix the build for `front_end/third_party/lit`. Bug: 370734442
1 parent b02ec69 commit 23940a9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

third_party/devtools-frontend/src/front_end/panels/network/RequestAdblockView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const coordinator = Coordinator.RenderCoordinator.RenderCoordinator.instance()
1414

1515
export class RequestAdblockView extends LegacyWrapper.LegacyWrapper
1616
.WrappableComponent {
17-
static readonly litTagName = LitHtml.literal`devtools-request-adblock-info`
17+
static readonly litTagName = LitHtml.StaticHtml.literal`devtools-request-adblock-info`
1818
readonly #shadow = this.attachShadow({ mode: 'open' })
1919
readonly #request: SDK.NetworkRequest.NetworkRequest
2020
#manager: SDK.NetworkManager.NetworkManager | null

0 commit comments

Comments
 (0)