Skip to content

Commit 195a79a

Browse files
committed
ci: drop Node 8 support
1 parent 0a7428e commit 195a79a

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

.circleci/config.yml

-17
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ aliases:
1111
- &node_lts_executor
1212
docker:
1313
- image: circleci/node:lts
14-
- &node_8_executor
15-
docker:
16-
- image: circleci/node:8
1714
- &default_executor
1815
<<: *node_latest_executor
1916
- &yarn_cache_key
@@ -104,15 +101,6 @@ jobs:
104101
name: Test with Node (LTS)
105102
command: yarn test
106103

107-
test_node_8:
108-
<<: *defaults
109-
<<: *node_8_executor
110-
steps:
111-
- *restore_repo
112-
- run:
113-
name: Test with Node (8)
114-
command: yarn run test
115-
116104
coverage:
117105
<<: *defaults
118106
<<: *default_executor
@@ -166,10 +154,6 @@ workflows:
166154
requires:
167155
- prepare
168156
<<: *ignore_non_dev_branches
169-
- test_node_8:
170-
requires:
171-
- prepare
172-
<<: *ignore_non_dev_branches
173157
- coverage:
174158
requires:
175159
- test_node_latest
@@ -180,6 +164,5 @@ workflows:
180164
- test_bundlesize
181165
- test_node_latest
182166
- test_node_lts
183-
- test_node_8
184167
- coverage
185168
<<: *execute_on_release

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
node_version: ['8.16', 10, 12] # Node 8 version fix due to https://github.com/actions/setup-node/issues/27
12+
node_version: [10, 12]
1313
os: [ubuntu-latest, windows-latest, macOS-latest]
1414

1515
runs-on: ${{ matrix.os }}

0 commit comments

Comments
 (0)