Skip to content

Commit 1c1879c

Browse files
SaturnFromTitanNico Cernek
authored and
Nico Cernek
committed
Remove TestData in frame tests in multiple files - part2 (pandas-dev#29222)
1 parent c5074c5 commit 1c1879c

File tree

5 files changed

+126
-127
lines changed

5 files changed

+126
-127
lines changed

pandas/tests/frame/test_reshape.py

+6-7
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66

77
import pandas as pd
88
from pandas import DataFrame, Index, MultiIndex, Period, Series, Timedelta, date_range
9-
from pandas.tests.frame.common import TestData
109
import pandas.util.testing as tm
1110
from pandas.util.testing import assert_frame_equal, assert_series_equal
1211

1312

14-
class TestDataFrameReshape(TestData):
13+
class TestDataFrameReshape:
1514
def test_pivot(self):
1615
data = {
1716
"index": ["A", "B", "C", "C", "B", "A"],
@@ -101,8 +100,8 @@ def test_pivot_index_none(self):
101100
expected.columns.name = "columns"
102101
tm.assert_frame_equal(result, expected)
103102

104-
def test_stack_unstack(self):
105-
df = self.frame.copy()
103+
def test_stack_unstack(self, float_frame):
104+
df = float_frame.copy()
106105
df[:] = np.arange(np.prod(df.shape)).reshape(df.shape)
107106

108107
stacked = df.stack()
@@ -515,13 +514,13 @@ def test_unstack_level_binding(self):
515514

516515
assert_frame_equal(result, expected)
517516

518-
def test_unstack_to_series(self):
517+
def test_unstack_to_series(self, float_frame):
519518
# check reversibility
520-
data = self.frame.unstack()
519+
data = float_frame.unstack()
521520

522521
assert isinstance(data, Series)
523522
undo = data.unstack().T
524-
assert_frame_equal(undo, self.frame)
523+
assert_frame_equal(undo, float_frame)
525524

526525
# check NA handling
527526
data = DataFrame({"x": [1, 2, np.NaN], "y": [3.0, 4, np.NaN]})

pandas/tests/frame/test_sorting.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@
1515
date_range,
1616
)
1717
from pandas.api.types import CategoricalDtype
18-
from pandas.tests.frame.common import TestData
1918
import pandas.util.testing as tm
2019
from pandas.util.testing import assert_frame_equal, assert_series_equal
2120

2221

23-
class TestDataFrameSorting(TestData):
22+
class TestDataFrameSorting:
2423
def test_sort_values(self):
2524
frame = DataFrame(
2625
[[1, 1, 2], [3, 1, 0], [4, 5, 6]], index=[1, 2, 3], columns=list("ABC")
@@ -295,8 +294,8 @@ def test_sort_datetimes(self):
295294
df2 = df.sort_values(by=["C", "B"])
296295
assert_frame_equal(df1, df2)
297296

298-
def test_frame_column_inplace_sort_exception(self):
299-
s = self.frame["A"]
297+
def test_frame_column_inplace_sort_exception(self, float_frame):
298+
s = float_frame["A"]
300299
with pytest.raises(ValueError, match="This Series is a view"):
301300
s.sort_values(inplace=True)
302301

@@ -379,7 +378,7 @@ def test_sort_nat(self):
379378
tm.assert_frame_equal(sorted_df, expected)
380379

381380

382-
class TestDataFrameSortIndexKinds(TestData):
381+
class TestDataFrameSortIndexKinds:
383382
def test_sort_index_multicolumn(self):
384383
A = np.arange(5).repeat(20)
385384
B = np.tile(np.arange(5), 20)

pandas/tests/frame/test_subclass.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33

44
import pandas as pd
55
from pandas import DataFrame, Index, MultiIndex, Series
6-
from pandas.tests.frame.common import TestData
76
import pandas.util.testing as tm
87

98

10-
class TestDataFrameSubclassing(TestData):
9+
class TestDataFrameSubclassing:
1110
def test_frame_subclassing_and_slicing(self):
1211
# Subclass frame and ensure it returns the right class on slicing it
1312
# In reference to PR 9632

pandas/tests/frame/test_timeseries.py

+68-65
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
period_range,
1818
to_datetime,
1919
)
20-
from pandas.tests.frame.common import TestData
2120
import pandas.util.testing as tm
2221
from pandas.util.testing import (
2322
assert_frame_equal,
@@ -33,12 +32,12 @@ def close_open_fixture(request):
3332
return request.param
3433

3534

36-
class TestDataFrameTimeSeriesMethods(TestData):
37-
def test_diff(self):
38-
the_diff = self.tsframe.diff(1)
35+
class TestDataFrameTimeSeriesMethods:
36+
def test_diff(self, datetime_frame):
37+
the_diff = datetime_frame.diff(1)
3938

4039
assert_series_equal(
41-
the_diff["A"], self.tsframe["A"] - self.tsframe["A"].shift(1)
40+
the_diff["A"], datetime_frame["A"] - datetime_frame["A"].shift(1)
4241
)
4342

4443
# int dtype
@@ -50,7 +49,7 @@ def test_diff(self):
5049
assert rs.s[1] == 1
5150

5251
# mixed numeric
53-
tf = self.tsframe.astype("float32")
52+
tf = datetime_frame.astype("float32")
5453
the_diff = tf.diff(1)
5554
assert_series_equal(the_diff["A"], tf["A"] - tf["A"].shift(1))
5655

@@ -126,14 +125,14 @@ def test_diff_mixed_dtype(self):
126125
result = df.diff()
127126
assert result[0].dtype == np.float64
128127

129-
def test_diff_neg_n(self):
130-
rs = self.tsframe.diff(-1)
131-
xp = self.tsframe - self.tsframe.shift(-1)
128+
def test_diff_neg_n(self, datetime_frame):
129+
rs = datetime_frame.diff(-1)
130+
xp = datetime_frame - datetime_frame.shift(-1)
132131
assert_frame_equal(rs, xp)
133132

134-
def test_diff_float_n(self):
135-
rs = self.tsframe.diff(1.0)
136-
xp = self.tsframe.diff(1)
133+
def test_diff_float_n(self, datetime_frame):
134+
rs = datetime_frame.diff(1.0)
135+
xp = datetime_frame.diff(1)
137136
assert_frame_equal(rs, xp)
138137

139138
def test_diff_axis(self):
@@ -142,20 +141,20 @@ def test_diff_axis(self):
142141
assert_frame_equal(df.diff(axis=1), DataFrame([[np.nan, 1.0], [np.nan, 1.0]]))
143142
assert_frame_equal(df.diff(axis=0), DataFrame([[np.nan, np.nan], [2.0, 2.0]]))
144143

145-
def test_pct_change(self):
146-
rs = self.tsframe.pct_change(fill_method=None)
147-
assert_frame_equal(rs, self.tsframe / self.tsframe.shift(1) - 1)
144+
def test_pct_change(self, datetime_frame):
145+
rs = datetime_frame.pct_change(fill_method=None)
146+
assert_frame_equal(rs, datetime_frame / datetime_frame.shift(1) - 1)
148147

149-
rs = self.tsframe.pct_change(2)
150-
filled = self.tsframe.fillna(method="pad")
148+
rs = datetime_frame.pct_change(2)
149+
filled = datetime_frame.fillna(method="pad")
151150
assert_frame_equal(rs, filled / filled.shift(2) - 1)
152151

153-
rs = self.tsframe.pct_change(fill_method="bfill", limit=1)
154-
filled = self.tsframe.fillna(method="bfill", limit=1)
152+
rs = datetime_frame.pct_change(fill_method="bfill", limit=1)
153+
filled = datetime_frame.fillna(method="bfill", limit=1)
155154
assert_frame_equal(rs, filled / filled.shift(1) - 1)
156155

157-
rs = self.tsframe.pct_change(freq="5D")
158-
filled = self.tsframe.fillna(method="pad")
156+
rs = datetime_frame.pct_change(freq="5D")
157+
filled = datetime_frame.fillna(method="pad")
159158
assert_frame_equal(
160159
rs, (filled / filled.shift(freq="5D") - 1).reindex_like(filled)
161160
)
@@ -181,17 +180,19 @@ def test_pct_change_shift_over_nas(self):
181180
("14B", 14, None, None),
182181
],
183182
)
184-
def test_pct_change_periods_freq(self, freq, periods, fill_method, limit):
183+
def test_pct_change_periods_freq(
184+
self, datetime_frame, freq, periods, fill_method, limit
185+
):
185186
# GH 7292
186-
rs_freq = self.tsframe.pct_change(
187+
rs_freq = datetime_frame.pct_change(
187188
freq=freq, fill_method=fill_method, limit=limit
188189
)
189-
rs_periods = self.tsframe.pct_change(
190+
rs_periods = datetime_frame.pct_change(
190191
periods, fill_method=fill_method, limit=limit
191192
)
192193
assert_frame_equal(rs_freq, rs_periods)
193194

194-
empty_ts = DataFrame(index=self.tsframe.index, columns=self.tsframe.columns)
195+
empty_ts = DataFrame(index=datetime_frame.index, columns=datetime_frame.columns)
195196
rs_freq = empty_ts.pct_change(freq=freq, fill_method=fill_method, limit=limit)
196197
rs_periods = empty_ts.pct_change(periods, fill_method=fill_method, limit=limit)
197198
assert_frame_equal(rs_freq, rs_periods)
@@ -249,39 +250,39 @@ def test_frame_append_datetime64_col_other_units(self):
249250

250251
assert (tmp["dates"].values == ex_vals).all()
251252

252-
def test_shift(self):
253+
def test_shift(self, datetime_frame, int_frame):
253254
# naive shift
254-
shiftedFrame = self.tsframe.shift(5)
255-
tm.assert_index_equal(shiftedFrame.index, self.tsframe.index)
255+
shiftedFrame = datetime_frame.shift(5)
256+
tm.assert_index_equal(shiftedFrame.index, datetime_frame.index)
256257

257-
shiftedSeries = self.tsframe["A"].shift(5)
258+
shiftedSeries = datetime_frame["A"].shift(5)
258259
assert_series_equal(shiftedFrame["A"], shiftedSeries)
259260

260-
shiftedFrame = self.tsframe.shift(-5)
261-
tm.assert_index_equal(shiftedFrame.index, self.tsframe.index)
261+
shiftedFrame = datetime_frame.shift(-5)
262+
tm.assert_index_equal(shiftedFrame.index, datetime_frame.index)
262263

263-
shiftedSeries = self.tsframe["A"].shift(-5)
264+
shiftedSeries = datetime_frame["A"].shift(-5)
264265
assert_series_equal(shiftedFrame["A"], shiftedSeries)
265266

266267
# shift by 0
267-
unshifted = self.tsframe.shift(0)
268-
assert_frame_equal(unshifted, self.tsframe)
268+
unshifted = datetime_frame.shift(0)
269+
assert_frame_equal(unshifted, datetime_frame)
269270

270271
# shift by DateOffset
271-
shiftedFrame = self.tsframe.shift(5, freq=offsets.BDay())
272-
assert len(shiftedFrame) == len(self.tsframe)
272+
shiftedFrame = datetime_frame.shift(5, freq=offsets.BDay())
273+
assert len(shiftedFrame) == len(datetime_frame)
273274

274-
shiftedFrame2 = self.tsframe.shift(5, freq="B")
275+
shiftedFrame2 = datetime_frame.shift(5, freq="B")
275276
assert_frame_equal(shiftedFrame, shiftedFrame2)
276277

277-
d = self.tsframe.index[0]
278+
d = datetime_frame.index[0]
278279
shifted_d = d + offsets.BDay(5)
279280
assert_series_equal(
280-
self.tsframe.xs(d), shiftedFrame.xs(shifted_d), check_names=False
281+
datetime_frame.xs(d), shiftedFrame.xs(shifted_d), check_names=False
281282
)
282283

283284
# shift int frame
284-
int_shifted = self.intframe.shift(1) # noqa
285+
int_shifted = int_frame.shift(1) # noqa
285286

286287
# Shifting with PeriodIndex
287288
ps = tm.makePeriodFrame()
@@ -387,7 +388,7 @@ def test_shift_duplicate_columns(self):
387388
assert_frame_equal(shifted[0], shifted[1])
388389
assert_frame_equal(shifted[0], shifted[2])
389390

390-
def test_tshift(self):
391+
def test_tshift(self, datetime_frame):
391392
# PeriodIndex
392393
ps = tm.makePeriodFrame()
393394
shifted = ps.tshift(1)
@@ -405,36 +406,36 @@ def test_tshift(self):
405406
ps.tshift(freq="M")
406407

407408
# DatetimeIndex
408-
shifted = self.tsframe.tshift(1)
409+
shifted = datetime_frame.tshift(1)
409410
unshifted = shifted.tshift(-1)
410411

411-
assert_frame_equal(self.tsframe, unshifted)
412+
assert_frame_equal(datetime_frame, unshifted)
412413

413-
shifted2 = self.tsframe.tshift(freq=self.tsframe.index.freq)
414+
shifted2 = datetime_frame.tshift(freq=datetime_frame.index.freq)
414415
assert_frame_equal(shifted, shifted2)
415416

416417
inferred_ts = DataFrame(
417-
self.tsframe.values,
418-
Index(np.asarray(self.tsframe.index)),
419-
columns=self.tsframe.columns,
418+
datetime_frame.values,
419+
Index(np.asarray(datetime_frame.index)),
420+
columns=datetime_frame.columns,
420421
)
421422
shifted = inferred_ts.tshift(1)
422423
unshifted = shifted.tshift(-1)
423-
assert_frame_equal(shifted, self.tsframe.tshift(1))
424+
assert_frame_equal(shifted, datetime_frame.tshift(1))
424425
assert_frame_equal(unshifted, inferred_ts)
425426

426-
no_freq = self.tsframe.iloc[[0, 5, 7], :]
427+
no_freq = datetime_frame.iloc[[0, 5, 7], :]
427428
msg = "Freq was not given and was not set in the index"
428429
with pytest.raises(ValueError, match=msg):
429430
no_freq.tshift()
430431

431-
def test_truncate(self):
432-
ts = self.tsframe[::3]
432+
def test_truncate(self, datetime_frame):
433+
ts = datetime_frame[::3]
433434

434-
start, end = self.tsframe.index[3], self.tsframe.index[6]
435+
start, end = datetime_frame.index[3], datetime_frame.index[6]
435436

436-
start_missing = self.tsframe.index[2]
437-
end_missing = self.tsframe.index[7]
437+
start_missing = datetime_frame.index[2]
438+
end_missing = datetime_frame.index[7]
438439

439440
# neither specified
440441
truncated = ts.truncate()
@@ -473,11 +474,11 @@ def test_truncate(self):
473474
before=ts.index[-1] - ts.index.freq, after=ts.index[0] + ts.index.freq
474475
)
475476

476-
def test_truncate_copy(self):
477-
index = self.tsframe.index
478-
truncated = self.tsframe.truncate(index[5], index[10])
477+
def test_truncate_copy(self, datetime_frame):
478+
index = datetime_frame.index
479+
truncated = datetime_frame.truncate(index[5], index[10])
479480
truncated.values[:] = 5.0
480-
assert not (self.tsframe.values[5:11] == 5).any()
481+
assert not (datetime_frame.values[5:11] == 5).any()
481482

482483
def test_truncate_nonsortedindex(self):
483484
# GH 17935
@@ -510,9 +511,9 @@ def test_truncate_nonsortedindex(self):
510511
with pytest.raises(ValueError, match=msg):
511512
df.truncate(before=2, after=20, axis=1)
512513

513-
def test_asfreq(self):
514-
offset_monthly = self.tsframe.asfreq(offsets.BMonthEnd())
515-
rule_monthly = self.tsframe.asfreq("BM")
514+
def test_asfreq(self, datetime_frame):
515+
offset_monthly = datetime_frame.asfreq(offsets.BMonthEnd())
516+
rule_monthly = datetime_frame.asfreq("BM")
516517

517518
tm.assert_almost_equal(offset_monthly["A"], rule_monthly["A"])
518519

@@ -523,7 +524,7 @@ def test_asfreq(self):
523524
filled_dep = rule_monthly.asfreq("B", method="pad") # noqa
524525

525526
# test does not blow up on length-0 DataFrame
526-
zero_length = self.tsframe.reindex([])
527+
zero_length = datetime_frame.reindex([])
527528
result = zero_length.asfreq("BM")
528529
assert result is not zero_length
529530

@@ -569,13 +570,15 @@ def test_asfreq_fillvalue(self):
569570
({"A": [1, np.nan, 3]}, [1, 2, 2], 1, 2),
570571
],
571572
)
572-
def test_first_last_valid(self, data, idx, expected_first, expected_last):
573-
N = len(self.frame.index)
573+
def test_first_last_valid(
574+
self, float_frame, data, idx, expected_first, expected_last
575+
):
576+
N = len(float_frame.index)
574577
mat = np.random.randn(N)
575578
mat[:5] = np.nan
576579
mat[-5:] = np.nan
577580

578-
frame = DataFrame({"foo": mat}, index=self.frame.index)
581+
frame = DataFrame({"foo": mat}, index=float_frame.index)
579582
index = frame.first_valid_index()
580583

581584
assert index == frame.index[5]

0 commit comments

Comments
 (0)