Skip to content

Commit 0df7cd6

Browse files
immaxchenNico Cernek
authored and
Nico Cernek
committed
CLN: Fix mypy error in pandas/tests/computation/test_eval.py (pandas-dev#29007)
1 parent 4bb2eee commit 0df7cd6

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

pandas/tests/computation/test_eval.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from functools import reduce
33
from itertools import product
44
import operator
5+
from typing import Dict, Type
56
import warnings
67

78
import numpy as np
@@ -19,7 +20,11 @@
1920
from pandas.core.computation.check import _NUMEXPR_VERSION
2021
from pandas.core.computation.engines import NumExprClobberingError, _engines
2122
import pandas.core.computation.expr as expr
22-
from pandas.core.computation.expr import PandasExprVisitor, PythonExprVisitor
23+
from pandas.core.computation.expr import (
24+
BaseExprVisitor,
25+
PandasExprVisitor,
26+
PythonExprVisitor,
27+
)
2328
from pandas.core.computation.expressions import _NUMEXPR_INSTALLED, _USE_NUMEXPR
2429
from pandas.core.computation.ops import (
2530
_arith_ops_syms,
@@ -1884,7 +1889,7 @@ def test_invalid_parser():
18841889
"python": PythonExprVisitor,
18851890
"pytables": pytables.ExprVisitor,
18861891
"pandas": PandasExprVisitor,
1887-
}
1892+
} # type: Dict[str, Type[BaseExprVisitor]]
18881893

18891894

18901895
@pytest.mark.parametrize("engine", _engines)

setup.cfg

-3
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,6 @@ ignore_errors=True
145145
[mypy-pandas.tests.arrays.test_period]
146146
ignore_errors=True
147147

148-
[mypy-pandas.tests.computation.test_eval]
149-
ignore_errors=True
150-
151148
[mypy-pandas.tests.dtypes.test_common]
152149
ignore_errors=True
153150

0 commit comments

Comments
 (0)