chore: migrate to golangci-lint v2 (#168)

* chore: migrate to golangci-lint v2

* chore: improve gofmt configuration

Author: ldez

.github/workflows/go.yml

@@ -15,9 +15,9 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: stable
-      - uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.63.4
+          version: v2.0.2
 
   tests:
     # run after golangci-lint action to not produce duplicated errors

.golangci.yml

@@ -1,58 +1,28 @@
 ---
-run:
-  timeout: 1m
-  issues-exit-code: 1
-  tests: true
+version: "2"
 
 output:
-  print-issued-lines: false
-  sort-results: true
   formats:
-    - format: colored-line-number
-
-linters-settings:
-  gocognit:
-    min-complexity: 10
-
-  depguard:
-    rules:
-      main:
-        deny:
-          - pkg: "github.com/davecgh/go-spew/spew"
-            desc: not allowed
-
-  misspell:
-    locale: US
-
-  gocritic:
-    # Enable multiple checks by tags, run `GL_DEBUG=gocritic golangci-lint run`
-    # to see all tags and checks. Empty list by default. See
-    # https://github.com/go-critic/go-critic#usage -> section "Tags".
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
+    text:
+      path: stdout
+      print-issued-lines: false
 
 linters:
-  enable-all: true
+  default: all
   disable:
     - cyclop
     - depguard
     - dupl
     - dupword
     - exhaustruct
-    - exportloopref
     - forbidigo
     - funlen
-    - gci
     - gocognit
     - gocyclo
     - godox
-    - mnd
     - lll
     - maintidx
+    - mnd
     - nakedret
     - nestif
     - nlreturn
@@ -64,8 +34,46 @@ linters:
     - varnamelen
     - wastedassign
 
+  settings:
+    depguard:
+      rules:
+        main:
+          deny:
+            - pkg: github.com/davecgh/go-spew/spew
+              desc: not allowed
+    gocognit:
+      min-complexity: 10
+    gocritic:
+      # Enable multiple checks by tags, run `GL_DEBUG=gocritic golangci-lint run`
+      # to see all tags and checks. Empty list by default. See
+      # https://github.com/go-critic/go-critic#usage -> section "Tags".
+      enabled-tags:
+        - diagnostic
+        - experimental
+        - opinionated
+        - performance
+        - style
+    misspell:
+      locale: US
+
+  exclusions:
+    presets:
+      - comments
+      - common-false-positives
+      - std-error-handling
+
 issues:
-  exclude-use-default: true
   max-issues-per-linter: 0
   max-same-issues: 0
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+  settings:
+    gofmt:
+      rewrite-rules:
+        - pattern: 'interface{}'
+          replacement: 'any'
+
 # vim: set sw=2 ts=2 et:

analyzer.go

@@ -79,7 +79,7 @@ func (wa *wslAnalyzer) flags() flag.FlagSet {
 	return *flags
 }
 
-func (wa *wslAnalyzer) run(pass *analysis.Pass) (interface{}, error) {
+func (wa *wslAnalyzer) run(pass *analysis.Pass) (any, error) {
 	for _, file := range pass.Files {
 		filename := getFilename(pass.Fset, file)
 		if !strings.HasSuffix(filename, ".go") {

wsl.go

@@ -1078,7 +1078,7 @@ func (p *processor) findBlockStmt(node ast.Node) []*ast.BlockStmt {
 // Known fields with X that are handled:
 // IndexExpr, ExprStmt, SelectorExpr, StarExpr, ParentExpr, TypeAssertExpr,
 // RangeStmt, UnaryExpr, ParenExpr, SliceExpr, IncDecStmt.
-func maybeX(node interface{}) (ast.Node, bool) {
+func maybeX(node any) (ast.Node, bool) {
 	maybeHasX := reflect.Indirect(reflect.ValueOf(node)).FieldByName("X")
 	if !maybeHasX.IsValid() {
 		return nil, false
@@ -1455,7 +1455,7 @@ func (p *processor) addErrorRange(reportAt, start, end token.Pos, reason string)
 	p.result[reportAt] = report
 }
 
-func (p *processor) addWarning(w string, pos token.Pos, t interface{}) {
+func (p *processor) addWarning(w string, pos token.Pos, t any) {
 	position := p.fileSet.Position(pos)
 
 	p.warnings = append(p.warnings,