Skip to content

Commit 7c3018f

Browse files
zackwzackw
committed
Suppress internal declarations for most of the testsuite.
This patch adds a new build module called 'testsuite'. IS_IN (testsuite) implies _ISOMAC, as do IS_IN_build and __cplusplus (which means several ad-hoc tests for __cplusplus can go away). libc-symbols.h now suppresses almost all of *itself* when _ISOMAC is defined; in particular, _ISOMAC mode does not get config.h automatically anymore. There are still quite a few tests that need to see internal gunk of one variety or another. For them, we now have 'tests-internal' and 'test-internal-extras'; files in this category will still be compiled with MODULE_NAME=nonlib, and everything proceeds as it always has. The bulk of this patch is moving tests from 'tests' to 'tests-internal'. There is also 'tests-static-internal', which has the same effect on files in 'tests-static', and 'modules-names-tests', which has the *inverse* effect on files in 'modules-names' (it's inverted because most of the things in modules-names are *not* tests). For both of these, the file must appear in *both* the new variable and the old one. There is also now a special case for when libc-symbols.h is included without MODULE_NAME being defined at all. (This happens during the creation of libc-modules.h, and also when preprocessing Versions files.) When this happens, IS_IN is set to be always false and _ISOMAC is *not* defined, which was the status quo, but now it's explicit. The remaining changes to C source files in this patch seemed likely to cause problems in the absence of the main change. They should be relatively self-explanatory. In a few cases I duplicated a definition from an internal header rather than move the test to tests-internal; this was a judgement call each time and I'm happy to change those however reviewers feel is more appropriate. * Makerules: New subdir configuration variables 'tests-internal' and 'test-internal-extras'. Test files in these categories will still be compiled with MODULE_NAME=nonlib. Test files in the existing categories (tests, xtests, test-srcs, test-extras) are now compiled with MODULE_NAME=testsuite. New subdir configuration variable 'modules-names-tests'. Files which are in both 'modules-names' and 'modules-names-tests' will be compiled with MODULE_NAME=testsuite instead of MODULE_NAME=extramodules. (gen-as-const-headers): Move to tests-internal. (do-tests-clean, common-mostlyclean): Support tests-internal. * Makeconfig (built-modules): Add testsuite. * Makefile: Change libof-check-installed-headers-c and libof-check-installed-headers-cxx to 'testsuite'. * Rules: Likewise. Support tests-internal. * benchtests/strcoll-inputs/filelist#en_US.UTF-8: Remove extra-modules.mk. * config.h.in: Don't check for __OPTIMIZE__ or __FAST_MATH__ here. * include/libc-symbols.h: Move definitions of _GNU_SOURCE, PASTE_NAME, PASTE_NAME1, IN_MODULE, IS_IN, and IS_IN_LIB to the very top of the file and rationalize their order. If MODULE_NAME is not defined at all, define IS_IN to always be false, and don't define _ISOMAC. If any of IS_IN (testsuite), IS_IN_build, or __cplusplus are true, define _ISOMAC and suppress everything else in this file, starting with the inclusion of config.h. Do check for inappropriate definitions of __OPTIMIZE__ and __FAST_MATH__ here, but only if _ISOMAC is not defined. Correct some out-of-date commentary. * include/math.h: If _ISOMAC is defined, undefine NO_LONG_DOUBLE and _Mlong_double_ before including math.h. * include/string.h: If _ISOMAC is defined, don't expose _STRING_ARCH_unaligned. Move a comment to a more appropriate location. * include/errno.h, include/stdio.h, include/stdlib.h, include/string.h * include/time.h, include/unistd.h, include/wchar.h: No need to check __cplusplus nor use __BEGIN_DECLS/__END_DECLS. * misc/sys/cdefs.h (__NTHNL): New macro. * sysdeps/m68k/m680x0/fpu/bits/mathinline.h (__m81_defun): Use __NTHNL to avoid errors with GCC 6. * elf/tst-env-setuid-tunables.c: Include config.h with _LIBC defined, for HAVE_TUNABLES. * inet/tst-checks-posix.c: No need to define _ISOMAC. * intl/tst-gettext2.c: Provide own definition of N_. * math/test-signgam-finite-c99.c: No need to define _ISOMAC. * math/test-signgam-main.c: No need to define _ISOMAC. * stdlib/tst-strtod.c: Convert to test-driver. Split locale_test to... * stdlib/tst-strtod1i.c: ...this new file. * stdlib/tst-strtod5.c: Convert to test-driver and add copyright notice. Split tests of __strtod_internal to... * stdlib/tst-strtod5i.c: ...this new file. * string/test-string.h: Include stdint.h. Duplicate definition of inhibit_loop_to_libcall here (from libc-symbols.h). * string/test-strstr.c: Provide dummy definition of libc_hidden_builtin_def when including strstr.c. * sysdeps/ia64/fpu/libm-symbols.h: Suppress entire file in _ISOMAC mode; no need to test __STRICT_ANSI__ nor __cplusplus as well. * sysdeps/x86_64/fpu/math-tests-arch.h: Include cpu-features.h. Don't include init-arch.h. * sysdeps/x86_64/multiarch/test-multiarch.h: Include cpu-features.h. Don't include init-arch.h. * elf/Makefile: Move tst-ptrguard1-static, tst-stackguard1-static, tst-tls1-static, tst-tls2-static, tst-tls3-static, loadtest, unload, unload2, circleload1, neededtest, neededtest2, neededtest3, neededtest4, tst-tls1, tst-tls2, tst-tls3, tst-tls6, tst-tls7, tst-tls8, tst-dlmopen2, tst-ptrguard1, tst-stackguard1, tst-_dl_addr_inside_object, and all of the ifunc tests to tests-internal. Don't add $(modules-names) to test-extras. * inet/Makefile: Move tst-inet6_scopeid_pton to tests-internal. Add tst-deadline to tests-static-internal. * malloc/Makefile: Move tst-mallocstate and tst-scratch_buffer to tests-internal. * misc/Makefile: Move tst-atomic and tst-atomic-long to tests-internal. * nptl/Makefile: Move tst-typesizes, tst-rwlock19, tst-sem11, tst-sem12, tst-sem13, tst-barrier5, tst-signal7, tst-tls3, tst-tls3-malloc, tst-tls5, tst-stackguard1, tst-sem11-static, tst-sem12-static, and tst-stackguard1-static to tests-internal. Link tests-internal with libpthread also. Don't add $(modules-names) to test-extras. * nss/Makefile: Move tst-field to tests-internal. * posix/Makefile: Move bug-regex5, bug-regex20, bug-regex33, tst-rfc3484, tst-rfc3484-2, and tst-rfc3484-3 to tests-internal. * stdlib/Makefile: Move tst-strtod1i, tst-strtod3, tst-strtod4, tst-strtod5i, tst-tls-atexit, and tst-tls-atexit-nodelete to tests-internal. * sunrpc/Makefile: Move tst-svc_register to tests-internal. * sysdeps/powerpc/Makefile: Move test-get_hwcap and test-get_hwcap-static to tests-internal. * sysdeps/unix/sysv/linux/Makefile: Move tst-setgetname to tests-internal. * sysdeps/x86_64/fpu/Makefile: Add all libmvec test modules to modules-names-tests.
1 parent 1711991 commit 7c3018f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+573
-257
lines changed

‎ChangeLog

Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,105 @@
1+
2017-05-11 Zack Weinberg <[email protected]>
2+
3+
* Makerules: New subdir configuration variables 'tests-internal'
4+
and 'test-internal-extras'. Test files in these categories will
5+
still be compiled with MODULE_NAME=nonlib. Test files in the
6+
existing categories (tests, xtests, test-srcs, test-extras) are
7+
now compiled with MODULE_NAME=testsuite.
8+
New subdir configuration variable 'modules-names-tests'. Files
9+
which are in both 'modules-names' and 'modules-names-tests' will
10+
be compiled with MODULE_NAME=testsuite instead of
11+
MODULE_NAME=extramodules.
12+
(gen-as-const-headers): Move to tests-internal.
13+
(do-tests-clean, common-mostlyclean): Support tests-internal.
14+
* Makeconfig (built-modules): Add testsuite.
15+
* Makefile: Change libof-check-installed-headers-c and
16+
libof-check-installed-headers-cxx to 'testsuite'.
17+
* Rules: Likewise. Support tests-internal.
18+
* benchtests/strcoll-inputs/filelist#en_US.UTF-8:
19+
Remove extra-modules.mk.
20+
21+
* config.h.in: Don't check for __OPTIMIZE__ or __FAST_MATH__ here.
22+
* include/libc-symbols.h: Move definitions of _GNU_SOURCE,
23+
PASTE_NAME, PASTE_NAME1, IN_MODULE, IS_IN, and IS_IN_LIB to the
24+
very top of the file and rationalize their order.
25+
If MODULE_NAME is not defined at all, define IS_IN to always be
26+
false, and don't define _ISOMAC.
27+
If any of IS_IN (testsuite), IS_IN_build, or __cplusplus are
28+
true, define _ISOMAC and suppress everything else in this file,
29+
starting with the inclusion of config.h.
30+
Do check for inappropriate definitions of __OPTIMIZE__ and
31+
__FAST_MATH__ here, but only if _ISOMAC is not defined.
32+
Correct some out-of-date commentary.
33+
34+
* include/math.h: If _ISOMAC is defined, undefine NO_LONG_DOUBLE
35+
and _Mlong_double_ before including math.h.
36+
* include/string.h: If _ISOMAC is defined, don't expose
37+
_STRING_ARCH_unaligned. Move a comment to a more appropriate
38+
location.
39+
40+
* include/errno.h, include/stdio.h, include/stdlib.h, include/string.h
41+
* include/time.h, include/unistd.h, include/wchar.h: No need to
42+
check __cplusplus nor use __BEGIN_DECLS/__END_DECLS.
43+
44+
* misc/sys/cdefs.h (__NTHNL): New macro.
45+
* sysdeps/m68k/m680x0/fpu/bits/mathinline.h
46+
(__m81_defun): Use __NTHNL to avoid errors with GCC 6.
47+
48+
* elf/tst-env-setuid-tunables.c: Include config.h with _LIBC
49+
defined, for HAVE_TUNABLES.
50+
* inet/tst-checks-posix.c: No need to define _ISOMAC.
51+
* intl/tst-gettext2.c: Provide own definition of N_.
52+
* math/test-signgam-finite-c99.c: No need to define _ISOMAC.
53+
* math/test-signgam-main.c: No need to define _ISOMAC.
54+
* stdlib/tst-strtod.c: Convert to test-driver. Split locale_test to...
55+
* stdlib/tst-strtod1i.c: ...this new file.
56+
* stdlib/tst-strtod5.c: Convert to test-driver and add copyright notice.
57+
Split tests of __strtod_internal to...
58+
* stdlib/tst-strtod5i.c: ...this new file.
59+
* string/test-string.h: Include stdint.h. Duplicate definition of
60+
inhibit_loop_to_libcall here (from libc-symbols.h).
61+
* string/test-strstr.c: Provide dummy definition of
62+
libc_hidden_builtin_def when including strstr.c.
63+
* sysdeps/ia64/fpu/libm-symbols.h: Suppress entire file in _ISOMAC
64+
mode; no need to test __STRICT_ANSI__ nor __cplusplus as well.
65+
* sysdeps/x86_64/fpu/math-tests-arch.h: Include cpu-features.h.
66+
Don't include init-arch.h.
67+
* sysdeps/x86_64/multiarch/test-multiarch.h: Include cpu-features.h.
68+
Don't include init-arch.h.
69+
70+
* elf/Makefile: Move tst-ptrguard1-static, tst-stackguard1-static,
71+
tst-tls1-static, tst-tls2-static, tst-tls3-static, loadtest,
72+
unload, unload2, circleload1, neededtest, neededtest2,
73+
neededtest3, neededtest4, tst-tls1, tst-tls2, tst-tls3,
74+
tst-tls6, tst-tls7, tst-tls8, tst-dlmopen2, tst-ptrguard1,
75+
tst-stackguard1, tst-_dl_addr_inside_object, and all of the
76+
ifunc tests to tests-internal.
77+
Don't add $(modules-names) to test-extras.
78+
* inet/Makefile: Move tst-inet6_scopeid_pton to tests-internal.
79+
Add tst-deadline to tests-static-internal.
80+
* malloc/Makefile: Move tst-mallocstate and tst-scratch_buffer to
81+
tests-internal.
82+
* misc/Makefile: Move tst-atomic and tst-atomic-long to tests-internal.
83+
* nptl/Makefile: Move tst-typesizes, tst-rwlock19, tst-sem11,
84+
tst-sem12, tst-sem13, tst-barrier5, tst-signal7, tst-tls3,
85+
tst-tls3-malloc, tst-tls5, tst-stackguard1, tst-sem11-static,
86+
tst-sem12-static, and tst-stackguard1-static to tests-internal.
87+
Link tests-internal with libpthread also.
88+
Don't add $(modules-names) to test-extras.
89+
* nss/Makefile: Move tst-field to tests-internal.
90+
* posix/Makefile: Move bug-regex5, bug-regex20, bug-regex33,
91+
tst-rfc3484, tst-rfc3484-2, and tst-rfc3484-3 to tests-internal.
92+
* stdlib/Makefile: Move tst-strtod1i, tst-strtod3, tst-strtod4,
93+
tst-strtod5i, tst-tls-atexit, and tst-tls-atexit-nodelete to
94+
tests-internal.
95+
* sunrpc/Makefile: Move tst-svc_register to tests-internal.
96+
* sysdeps/powerpc/Makefile: Move test-get_hwcap and
97+
test-get_hwcap-static to tests-internal.
98+
* sysdeps/unix/sysv/linux/Makefile: Move tst-setgetname to
99+
tests-internal.
100+
* sysdeps/x86_64/fpu/Makefile: Add all libmvec test modules to
101+
modules-names-tests.
102+
1103
2017-05-11 Zack Weinberg <[email protected]>
2104

3105
* libio/libio.h: Condition dummy definition of _IO_lock_t on

‎Makeconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,8 @@ libio-include = -I$(..)libio
908908
# List of non-library modules that we build.
909909
built-modules = iconvprogs iconvdata ldconfig lddlibc4 libmemusage \
910910
libSegFault libpcprofile librpcsvc locale-programs \
911-
memusagestat nonlib nscd extramodules libnldbl libsupport
911+
memusagestat nonlib nscd extramodules libnldbl libsupport \
912+
testsuite
912913

913914
in-module = $(subst -,_,$(firstword $(libof-$(basename $(@F))) \
914915
$(libof-$(<F)) \

‎Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ $(objpfx)check-local-headers.out: scripts/check-local-headers.sh
270270
ifneq "$(headers)" ""
271271
# Special test of all the installed headers in this directory.
272272
tests-special += $(objpfx)check-installed-headers-c.out
273-
libof-check-installed-headers-c := nonlib
273+
libof-check-installed-headers-c := testsuite
274274
$(objpfx)check-installed-headers-c.out: \
275275
scripts/check-installed-headers.sh $(headers)
276276
$(SHELL) $(..)scripts/check-installed-headers.sh c \
@@ -280,7 +280,7 @@ $(objpfx)check-installed-headers-c.out: \
280280

281281
ifneq "$(CXX)" ""
282282
tests-special += $(objpfx)check-installed-headers-cxx.out
283-
libof-check-installed-headers-cxx := nonlib
283+
libof-check-installed-headers-cxx := testsuite
284284
$(objpfx)check-installed-headers-cxx.out: \
285285
scripts/check-installed-headers.sh $(headers)
286286
$(SHELL) $(..)scripts/check-installed-headers.sh c++ \

‎Makerules

Lines changed: 42 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ $(common-objpfx)%.h $(common-objpfx)%.h.d: $(..)scripts/gen-as-const.awk \
277277
vpath %.sym $(sysdirs)
278278
before-compile += $(gen-as-const-headers:%.sym=$(common-objpfx)%.h)
279279

280-
tests += $(gen-as-const-headers:%.sym=test-as-const-%)
280+
tests-internal += $(gen-as-const-headers:%.sym=test-as-const-%)
281281
generated += $(gen-as-const-headers:%.sym=test-as-const-%.c)
282282
$(objpfx)test-as-const-%.c: $(..)scripts/gen-as-const.awk $(..)Makerules \
283283
%.sym $(common-objpfx)%.h
@@ -793,10 +793,21 @@ endif
793793

794794
# The makefile may define $(modules-names) to build additional modules.
795795
# These are built with $(build-module), except any in $(modules-names-nobuild).
796+
# MODULE_NAME=extramodules, except any in $(modules-names-tests).
796797
ifdef modules-names
797-
cpp-srcs-left := $(modules-names)
798-
lib = extramodules
799-
include $(patsubst %,$(..)libof-iterator.mk,$(modules-names))
798+
cpp-srcs-left := $(filter-out $(modules-names-tests),$(modules-names))
799+
ifneq (,$(cpp-srcs-left))
800+
lib := extramodules
801+
include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
802+
endif
803+
804+
ifdef modules-names-tests
805+
cpp-srcs-left := $(filter $(modules-names-tests),$(modules-names))
806+
ifneq (,$(cpp-srcs-left))
807+
lib := testsuite
808+
include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
809+
endif
810+
endif
800811

801812
extra-modules-build := $(filter-out $(modules-names-nobuild),$(modules-names))
802813
$(extra-modules-build:%=$(objpfx)%.so): $(objpfx)%.so: \
@@ -808,7 +819,7 @@ endif
808819
$(patsubst %.o,%.d,$(filter %.o,$(extra-objs:.os=.o))) \
809820
$(patsubst %.oS,%.d,$(filter %.oS,$(extra-objs))) \
810821
$(patsubst %.o,%.d,$(filter %.o,$(extra-test-objs:.os=.o))) \
811-
$(addsuffix .d,$(tests) $(xtests) $(test-srcs))
822+
$(addsuffix .d,$(tests) $(tests-internal) $(xtests) $(test-srcs))
812823
ifeq ($(build-programs),yes)
813824
+depfiles += $(addsuffix .d,$(others) $(sysdep-others))
814825
endif
@@ -1321,7 +1332,17 @@ check: tests
13211332
.PHONY: xcheck
13221333
xcheck: xtests
13231334

1324-
all-nonlib = $(strip $(tests) $(xtests) $(test-srcs) $(test-extras) $(others))
1335+
# The only difference between MODULE_NAME=testsuite and MODULE_NAME=nonlib is
1336+
# that almost all internal declarations from config.h, libc-symbols.h, and
1337+
# include/*.h are not available to 'testsuite' code, but are to 'nonlib' code.
1338+
all-testsuite := $(strip $(tests) $(xtests) $(test-srcs) $(test-extras))
1339+
ifneq (,$(all-testsuite))
1340+
cpp-srcs-left = $(all-testsuite)
1341+
lib := testsuite
1342+
include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
1343+
endif
1344+
1345+
all-nonlib := $(strip $(tests-internal) $(test-internal-extras) $(others))
13251346
ifneq (,$(all-nonlib))
13261347
cpp-srcs-left = $(all-nonlib)
13271348
lib := nonlib
@@ -1535,22 +1556,32 @@ clean: common-clean
15351556
mostlyclean: common-mostlyclean
15361557

15371558
do-tests-clean:
1538-
-rm -f $(addprefix $(objpfx),$(addsuffix .out,$(tests) $(xtests) \
1559+
-rm -f $(addprefix $(objpfx),$(addsuffix .out,$(tests) \
1560+
$(tests-internal) \
1561+
$(xtests) \
15391562
$(test-srcs)) \
15401563
$(addsuffix .test-result,$(tests) \
1564+
$(tests-internal) \
15411565
$(xtests) \
15421566
$(test-srcs)))
15431567

15441568
# Remove the object files.
15451569
common-mostlyclean:
1546-
-rm -f $(addprefix $(objpfx),$(tests) $(xtests) $(test-srcs) \
1570+
-rm -f $(addprefix $(objpfx),$(tests) $(tests-internal) $(xtests) \
1571+
$(test-srcs) \
15471572
$(others) $(sysdep-others) stubs \
1548-
$(addsuffix .o,$(tests) $(xtests) \
1549-
$(test-srcs) $(others) \
1573+
$(addsuffix .o,$(tests) \
1574+
$(tests-internal) \
1575+
$(xtests) \
1576+
$(test-srcs) \
1577+
$(others) \
15501578
$(sysdep-others)) \
1551-
$(addsuffix .out,$(tests) $(xtests) \
1579+
$(addsuffix .out,$(tests) \
1580+
$(tests-internal) \
1581+
$(xtests) \
15521582
$(test-srcs)) \
15531583
$(addsuffix .test-result,$(tests) \
1584+
$(tests-internal) \
15541585
$(xtests) \
15551586
$(test-srcs)))
15561587
-rm -f $(addprefix $(objpfx),$(extra-objs) $(extra-test-objs) \

‎Rules

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ common-generated += dummy.o dummy.c
8484
ifneq "$(headers)" ""
8585
# Special test of all the installed headers in this directory.
8686
tests-special += $(objpfx)check-installed-headers-c.out
87-
libof-check-installed-headers-c := nonlib
87+
libof-check-installed-headers-c := testsuite
8888
$(objpfx)check-installed-headers-c.out: \
8989
$(..)scripts/check-installed-headers.sh $(headers)
9090
$(SHELL) $(..)scripts/check-installed-headers.sh c \
@@ -94,7 +94,7 @@ $(objpfx)check-installed-headers-c.out: \
9494

9595
ifneq "$(CXX)" ""
9696
tests-special += $(objpfx)check-installed-headers-cxx.out
97-
libof-check-installed-headers-cxx := nonlib
97+
libof-check-installed-headers-cxx := testsuite
9898
$(objpfx)check-installed-headers-cxx.out: \
9999
$(..)scripts/check-installed-headers.sh $(headers)
100100
$(SHELL) $(..)scripts/check-installed-headers.sh c++ \
@@ -129,12 +129,14 @@ endif
129129
others: $(py-const)
130130

131131
ifeq ($(run-built-tests),no)
132-
tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests)) \
132+
tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported), \
133+
$(tests) $(tests-internal)) \
133134
$(test-srcs)) $(tests-special) \
134135
$(tests-printers-programs)
135136
xtests: tests $(xtests-special)
136137
else
137-
tests: $(tests:%=$(objpfx)%.out) $(tests-special) $(tests-printers-out)
138+
tests: $(tests:%=$(objpfx)%.out) $(tests-internal:%=$(objpfx)%.out) \
139+
$(tests-special) $(tests-printers-out)
138140
xtests: tests $(xtests:%=$(objpfx)%.out) $(xtests-special)
139141
endif
140142

@@ -143,7 +145,7 @@ xtests-special-notdir = $(patsubst $(objpfx)%, %, $(xtests-special))
143145
ifeq ($(run-built-tests),no)
144146
tests-expected =
145147
else
146-
tests-expected = $(tests) $(tests-printers)
148+
tests-expected = $(tests) $(tests-internal) $(tests-printers)
147149
endif
148150
tests:
149151
$(..)scripts/merge-test-results.sh -s $(objpfx) $(subdir) \
@@ -156,7 +158,7 @@ xtests:
156158

157159
ifeq ($(build-programs),yes)
158160
binaries-all-notests = $(others) $(sysdep-others)
159-
binaries-all-tests = $(tests) $(xtests) $(test-srcs)
161+
binaries-all-tests = $(tests) $(tests-internal) $(xtests) $(test-srcs)
160162
binaries-all = $(binaries-all-notests) $(binaries-all-tests)
161163
binaries-static-notests = $(others-static)
162164
binaries-static-tests = $(tests-static) $(xtests-static)
@@ -170,7 +172,7 @@ binaries-pie-notests =
170172
endif
171173
else
172174
binaries-all-notests =
173-
binaries-all-tests = $(tests) $(xtests) $(test-srcs)
175+
binaries-all-tests = $(tests) $(tests-internal) $(xtests) $(test-srcs)
174176
binaries-all = $(binaries-all-tests)
175177
binaries-static-notests =
176178
binaries-static-tests =
@@ -230,7 +232,7 @@ $(addprefix $(objpfx),$(binaries-static-tests)): %: %.o \
230232
$(+link-static-tests)
231233
endif
232234

233-
ifneq "$(strip $(tests) $(xtests) $(test-srcs))" ""
235+
ifneq "$(strip $(tests) $(tests-internal) $(xtests) $(test-srcs))" ""
234236
# These are the implicit rules for making test outputs
235237
# from the test programs and whatever input files are present.
236238

‎config.h.in

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
1-
#if !defined IS_IN_build && !defined __ASSEMBLER__ && !defined _ISOMAC \
2-
&& !defined __OPTIMIZE__
3-
# error "glibc cannot be compiled without optimization"
4-
#endif
5-
6-
/* Another evil option when it comes to compiling the C library is
7-
--ffast-math since it alters the ABI. */
8-
#if defined __FAST_MATH__ && !defined TEST_FAST_MATH
9-
# error "glibc must not be compiled with -ffast-math"
10-
#endif
11-
121
/* Define if building with SELinux support. Set by --with-selinux. */
132
#undef HAVE_SELINUX
143

0 commit comments

Comments
 (0)