Skip to content

Commit 5f4a8c5

Browse files
togami2864togami2864
authored
chore(linter): rename useConsistentGridAreas to noInvalidGridAreas (#3809)
1 parent 72c6ce6 commit 5f4a8c5

File tree

11 files changed

+104
-103
lines changed

11 files changed

+104
-103
lines changed

‎crates/biome_configuration/src/analyzer/linter/rules.rs

Lines changed: 74 additions & 74 deletions
Large diffs are not rendered by default.

‎crates/biome_css_analyze/src/lint/nursery.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ pub mod no_duplicate_selectors_keyframe_block;
88
pub mod no_empty_block;
99
pub mod no_important_in_keyframe;
1010
pub mod no_invalid_direction_in_linear_gradient;
11+
pub mod no_invalid_grid_areas;
1112
pub mod no_invalid_position_at_import_rule;
1213
pub mod no_irregular_whitespace;
1314
pub mod no_shorthand_property_overrides;
@@ -19,7 +20,6 @@ pub mod no_unknown_selector_pseudo_element;
1920
pub mod no_unknown_unit;
2021
pub mod no_unmatchable_anb_selector;
2122
pub mod no_value_at_rule;
22-
pub mod use_consistent_grid_areas;
2323
pub mod use_generic_font_names;
2424

2525
declare_lint_group! {
@@ -32,6 +32,7 @@ declare_lint_group! {
3232
self :: no_empty_block :: NoEmptyBlock ,
3333
self :: no_important_in_keyframe :: NoImportantInKeyframe ,
3434
self :: no_invalid_direction_in_linear_gradient :: NoInvalidDirectionInLinearGradient ,
35+
self :: no_invalid_grid_areas :: NoInvalidGridAreas ,
3536
self :: no_invalid_position_at_import_rule :: NoInvalidPositionAtImportRule ,
3637
self :: no_irregular_whitespace :: NoIrregularWhitespace ,
3738
self :: no_shorthand_property_overrides :: NoShorthandPropertyOverrides ,
@@ -43,7 +44,6 @@ declare_lint_group! {
4344
self :: no_unknown_unit :: NoUnknownUnit ,
4445
self :: no_unmatchable_anb_selector :: NoUnmatchableAnbSelector ,
4546
self :: no_value_at_rule :: NoValueAtRule ,
46-
self :: use_consistent_grid_areas :: UseConsistentGridAreas ,
4747
self :: use_generic_font_names :: UseGenericFontNames ,
4848
]
4949
}

‎crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs renamed to ‎crates/biome_css_analyze/src/lint/nursery/no_invalid_grid_areas.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ declare_lint_rule! {
4848
/// "a a a"; }
4949
/// ```
5050
///
51-
pub UseConsistentGridAreas {
51+
pub NoInvalidGridAreas {
5252
version: "next",
53-
name: "useConsistentGridAreas",
53+
name: "noInvalidGridAreas",
5454
language: "css",
5555
recommended: false,
5656
sources: &[RuleSource::Stylelint("named-grid-areas-no-invalid")],
@@ -73,7 +73,7 @@ pub struct UseConsistentGridAreasState {
7373
reason: GridAreaValidationError,
7474
}
7575

76-
impl Rule for UseConsistentGridAreas {
76+
impl Rule for NoInvalidGridAreas {
7777
type Query = Ast<CssDeclarationOrRuleList>;
7878
type State = UseConsistentGridAreasState;
7979
type Signals = Option<Self::State>;

‎crates/biome_css_analyze/src/options.rs

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎crates/biome_css_analyze/tests/specs/nursery/useConsistentGridAreas/invalid.css renamed to ‎crates/biome_css_analyze/tests/specs/nursery/noInvalidGridAreas/invalid.css

File renamed without changes.

‎crates/biome_css_analyze/tests/specs/nursery/useConsistentGridAreas/invalid.css.snap renamed to ‎crates/biome_css_analyze/tests/specs/nursery/noInvalidGridAreas/invalid.css.snap

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ a { grid-template-areas: "a a a"
3737

3838
# Diagnostics
3939
```
40-
invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
40+
invalid.css:1:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
4141
4242
! Empty grid areas are not allowed.
4343
@@ -52,7 +52,7 @@ invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
5252
```
5353

5454
```
55-
invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
55+
invalid.css:2:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
5656
5757
! Inconsistent cell count in grid areas are not allowed.
5858
@@ -68,7 +68,7 @@ invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
6868
```
6969
7070
```
71-
invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
71+
invalid.css:4:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
7272
7373
! Empty grid areas are not allowed.
7474
@@ -87,7 +87,7 @@ invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
8787
```
8888
8989
```
90-
invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
90+
invalid.css:6:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
9191
9292
! Duplicate filled in rectangle are not allowed.
9393
@@ -106,7 +106,7 @@ invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
106106
```
107107
108108
```
109-
invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
109+
invalid.css:11:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
110110
111111
! Duplicate filled in rectangle are not allowed.
112112
@@ -125,7 +125,7 @@ invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
125125
```
126126
127127
```
128-
invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
128+
invalid.css:15:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
129129
130130
! Duplicate filled in rectangle are not allowed.
131131
@@ -144,7 +144,7 @@ invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
144144
```
145145
146146
```
147-
invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
147+
invalid.css:17:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
148148
149149
! Duplicate filled in rectangle are not allowed.
150150
@@ -163,7 +163,7 @@ invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
163163
```
164164
165165
```
166-
invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
166+
invalid.css:21:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
167167
168168
! Inconsistent cell count in grid areas are not allowed.
169169
@@ -182,7 +182,7 @@ invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
182182
```
183183
184184
```
185-
invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
185+
invalid.css:24:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
186186
187187
! Duplicate filled in rectangle are not allowed.
188188
@@ -201,7 +201,7 @@ invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
201201
```
202202
203203
```
204-
invalid.css:27:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
204+
invalid.css:27:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
205205
206206
! Duplicate filled in rectangle are not allowed.
207207

‎crates/biome_css_analyze/tests/specs/nursery/useConsistentGridAreas/valid.css renamed to ‎crates/biome_css_analyze/tests/specs/nursery/noInvalidGridAreas/valid.css

File renamed without changes.

‎crates/biome_css_analyze/tests/specs/nursery/useConsistentGridAreas/valid.css.snap renamed to ‎crates/biome_css_analyze/tests/specs/nursery/noInvalidGridAreas/valid.css.snap

File renamed without changes.

‎crates/biome_diagnostics_categories/src/categories.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ define_categories! {
159159
"lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
160160
"lint/nursery/useConsistentBuiltinInstantiation": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
161161
"lint/nursery/useConsistentCurlyBraces": "https://biomejs.dev/linter/rules/use-consistent-curly-braces",
162-
"lint/nursery/useConsistentGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
162+
"lint/nursery/noInvalidGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
163163
"lint/nursery/useConsistentMemberAccessibility": "https://biomejs.dev/linter/rules/use-consistent-member-accessibility",
164164
"lint/nursery/useDateNow": "https://biomejs.dev/linter/rules/use-date-now",
165165
"lint/nursery/useDefaultSwitchClause": "https://biomejs.dev/linter/rules/use-default-switch-clause",

‎packages/@biomejs/backend-jsonrpc/src/workspace.ts

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@biomejs/biome/configuration_schema.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)