Skip to content

Commit 0524e92

Browse files
juliemrpetebacondarwin
authored andcommitted
docs(migration): add end to end upgrade info to migration doc
There are a couple of changes to some Protractor tests that need to be made when migrating from AngularJS 1.2 to 1.3 - document these in the migration guide. See angular/protractor#1480 Closes angular#10377
1 parent 9b96cea commit 0524e92

File tree

1 file changed

+39
-0
lines changed

1 file changed

+39
-0
lines changed

docs/content/guide/migration.ngdoc

+39
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,45 @@ After:
450450
Please view the documentation for ngAnimate for more info.
451451

452452

453+
## Testing
454+
455+
- due to [85880a64](https://github.com/angular/angular.js/commit/85880a64900fa22a61feb926bf52de0965332ca5), some deprecated features of
456+
Protractor tests no longer work.
457+
458+
`by.binding(descriptor)` no longer allows using the surrounding interpolation
459+
markers in the descriptor (the default interpolation markers are `{{}}`).
460+
Previously, these were optional.
461+
462+
Before:
463+
464+
var el = element(by.binding('{{foo}}'));
465+
466+
After:
467+
468+
var el = element(by.binding('foo'));
469+
470+
Prefixes `ng_` and `x-ng-` are no longer allowed for models. Use `ng-model`.
471+
472+
`by.repeater` cannot find elements by row and column which are not children of
473+
the row. For example, if your template is
474+
475+
<div ng-repeat="foo in foos">{{foo.name}}</div>
476+
477+
Before:
478+
479+
var el = element(by.repeater('foo in foos').row(2).column('foo.name'))
480+
481+
After:
482+
483+
You may either enclose `{{foo.name}}` in a child element
484+
485+
<div ng-repeat="foo in foos"><span>{{foo.name}}</span></div>
486+
487+
or simply use:
488+
489+
var el = element(by.repeater('foo in foos').row(2))
490+
491+
453492
## Internet Explorer 8
454493

455494
- due to [eaa1d00b](https://github.com/angular/angular.js/commit/eaa1d00b24008f590b95ad099241b4003688cdda),

0 commit comments

Comments
 (0)