Fix deployment for v11

[mgechev]

Because we removed some experimental APIs (promoted them as public in v11), the deployment builder no longer works.

It should be relatively easy to migrate. Here's an example from AngularFire angular/angularfire#2643.

[dianjuar]

@mgechev I found a problem here, hope you can lead me with it.

I was following Angular Fire PR that you brought, I see that they use context.getTargetOptions to get the project's outputPath but for a library that property is not being returned.

Do you know if to get the outputPath for a library we need to use another method different than .getTargetOptions?

---

I think I have a workaround but I feel it's too nasty 🤮, .getTargetOptions returns the path for the file projects/{MY-LIB-NAME}/ng-package.json and that file has the following structure.

{
  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
  "dest": "../../dist/{MY-LIB-NAME}",
  "lib": {
    "entryFile": "src/public-api.ts"
  }
}

I can read that file, and get the dest property to get the outPath that I need. What do you think about this?

[mgechev]

Doesn't sound that terrible to me, if you can always resolve the location of the library package configuration.

The only risky thing here would be if ng-packagr changes their configuration file.

[dianjuar]

@mgechev I'm going to implement the solution that I mentioned to have V11 support ASAP, I think is the only way to go with this.

I wonder if the BuilderContext.getTargetOptions should give me those options or the function is only limited to get information that is on the angular.json and I'm forced to go with the ng-package.json to get more information about the library that I'm building?

[mgechev]

You could open an issue in angular-cli and get more feedback there from the CLI team.

[JohannesHoppe]

It also wasn't my best idea to introduce the --configuration param. 😅
I think we want a deprecation of configuration to get out of this situation. I'm right now trying to correct this for angular-cli-ghpages.

See
angular/angularfire#2063 (comment)
angular-schule#1 (comment)

[dianjuar]

I am having a good family time 😄.
I will work on this over the weekend

[JohannesHoppe]

I will port back all changes to the starter, soon.

[dianjuar]

Thank you @mgechev for let me know about this problem so early.

The fix is ready under the version [email protected] 🚀