Skip to content

Commit 8b4bb8c

Browse files
authored
ci: try another technique to download reports on sonar workflow (#675)
1 parent 924e114 commit 8b4bb8c

File tree

5 files changed

+32
-7
lines changed

5 files changed

+32
-7
lines changed
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
name: Download Builds
22
description: Downloading the github artifact created with the build (dist folder)
3+
4+
inputs:
5+
sha:
6+
description: 'SHA to use for the artifact name'
7+
required: false
8+
default: ${{ github.sha }}
9+
310
runs:
411
using: composite
512
steps:
613
- name: Download dist folder
714
uses: actions/download-artifact@v4
815
with:
9-
name: library-dist-${{ github.event.workflow_run.head_sha || github.sha }}
16+
name: library-dist-${{ inputs.sha }}
1017
path: dist
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
name: Download Coverage Reports
22
description: Download the github artifact created with the `test --coverage`
3+
4+
inputs:
5+
sha:
6+
description: 'SHA to use for the artifact name'
7+
required: false
8+
default: ${{ github.sha }}
9+
310
runs:
411
using: composite
512
steps:
613
- name: Download coverage report
714
uses: actions/download-artifact@v4
815
with:
9-
name: ngx-deploy-npm-coverage-report-${{ github.event.workflow_run.head_sha || github.sha }}
16+
name: ngx-deploy-npm-coverage-report-${{ inputs.sha }}
1017
path: coverage/packages/ngx-deploy-npm
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
name: Download Lint Reports
22
description: Download the github artifact with the lint report
3+
4+
inputs:
5+
sha:
6+
description: 'SHA to use for the artifact name'
7+
required: false
8+
default: ${{ github.sha }}
9+
310
runs:
411
using: composite
512
steps:
613
- name: Download lint report
714
uses: actions/download-artifact@v4
815
with:
9-
name: lint-report-${{ github.event.workflow_run.head_sha || github.sha }}
16+
name: lint-report-${{ inputs.sha }}
1017
path: reports

.github/workflows/pr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Check if Prettier was run
3636
run: npx pretty-quick --check
3737

38-
backwards-compatibility-test:
39-
name: Backwards compatibility test
40-
needs: [pr-test]
41-
uses: ./.github/workflows/backwards-compatibility-test.yml
38+
# backwards-compatibility-test:
39+
# name: Backwards compatibility test
40+
# needs: [pr-test]
41+
# uses: ./.github/workflows/backwards-compatibility-test.yml

.github/workflows/sonar-pr.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ jobs:
1818

1919
# Download reports
2020
- uses: ./.github/actions/download-coverage-report
21+
with:
22+
sha: ${{ github.event.workflow_run.head_sha }}
2123
- uses: ./.github/actions/download-lint-report
24+
with:
25+
sha: ${{ github.event.workflow_run.head_sha }}
2226

2327
- name: SonarCloud Scan
2428
uses: sonarsource/sonarcloud-github-action@master

0 commit comments

Comments
 (0)