Skip to content

Commit 57c4356

Browse files
ci: 📦 github artifact actions to v4 (major) (#639)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Diego Juliao <[email protected]>
1 parent 53a4f59 commit 57c4356

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

.github/actions/download-build/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download dist folder
7-
uses: actions/download-artifact@v3
7+
uses: actions/download-artifact@v4
88
with:
99
name: library-dist-${{ github.sha }}
1010
path: dist

.github/actions/download-coverage-report/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download coverage report
7-
uses: actions/download-artifact@v3
7+
uses: actions/download-artifact@v4
88
with:
99
name: ngx-deploy-npm-coverage-report-${{ github.sha }}
1010
path: coverage/packages/ngx-deploy-npm

.github/actions/download-lint-report/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download lint report
7-
uses: actions/download-artifact@v3
7+
uses: actions/download-artifact@v4
88
with:
99
name: lint-report-${{ github.sha }}
1010
path: reports

.github/workflows/basic-test.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
run: npx nx lint-report ngx-deploy-npm
1717

1818
- name: Archive lint report results
19-
uses: actions/upload-artifact@v3
19+
uses: actions/upload-artifact@v4
2020
with:
2121
name: lint-report-${{ github.sha }}
2222
path: reports
@@ -30,7 +30,7 @@ jobs:
3030
- run: npx nx build ngx-deploy-npm
3131

3232
- name: Archive build result
33-
uses: actions/upload-artifact@v3
33+
uses: actions/upload-artifact@v4
3434
with:
3535
name: library-dist-${{ github.sha }}
3636
path: dist
@@ -49,9 +49,17 @@ jobs:
4949

5050
- run: npx nx test ngx-deploy-npm --configuration="ci"
5151

52-
- if: ${{ matrix.os == 'ubuntu-latest' }}
52+
- name: Set Node.js version based on .nvmrc
53+
shell: bash
54+
run: |
55+
version=$(cat .nvmrc)
56+
echo "Setting default value for node-version parameter: $version"
57+
echo "NODE_VERSION=$version" >> $GITHUB_ENV
58+
echo "$NODE_VERSION"
59+
60+
- if: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == env.NODE_VERSION }}
5361
name: Archive coverage report
54-
uses: actions/upload-artifact@v3
62+
uses: actions/upload-artifact@v4
5563
with:
5664
name: ngx-deploy-npm-coverage-report-${{ github.sha }}
5765
path: coverage/packages/ngx-deploy-npm/lcov.info

.github/workflows/publishment.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ on:
66

77
jobs:
88
test:
9-
if: ${{ !contains(github.event.head_commit.message, 'chore(release)') }}
109
uses: ./.github/workflows/basic-test.yml
1110

1211
e2e-test:
13-
if: ${{ !contains(github.event.head_commit.message, 'chore(release)') }}
1412
uses: ./.github/workflows/e2e-test.yml
1513

1614
backwards-compatibility-test:

0 commit comments

Comments
 (0)