Fetch user data at the begining of requests

Registering that function to express middleware is much
more clean and easy way, but it causes uncessary db calls.

Author: joybro

server/apis/auth.js

@@ -41,19 +41,25 @@ const signin = async (req) => {
   console.log({ file, function: 'signin', user });
 
   const result = {
-    uid: fbUserInfo.id,
-    name: fbUserInfo.name,
-    pictureUrl: fbUserInfo.picture,
+    uid: user.id,
+    name: user.name,
+    pictureUrl: user.pictureUrl,
     fbToken: req.body.fbToken,
   };
 
-  session.updateAuthResult(req, result);
+  session.update(req, {
+    uid: user.id,
+    fbToken: req.body.fbToken,
+  });
 
   return result;
 };
 
 const signout = (req) => {
-  session.updateAuthResult(req, {});
+  session.update(req, {
+    uid: null,
+    fbToken: null,
+  });
 
   return {};
 };

server/app.js

@@ -13,6 +13,7 @@ import createReduxStore from '../modules/store';
 
 import auth from './apis/auth';
 import session from './libs/session';
+import userMiddleware from './libs/userMiddleware';
 
 import App from '../src/containers/App';
 
@@ -24,16 +25,16 @@ app.use(bodyParser.json()); // for parsing POST body
 app.use(session.createSessionMiddleware());
 app.use(express.static(path.join(__dirname, './public')));
 
-app.get('*', (req, res) => {
-  console.log({ function:'app.get', req: { url: req.url } });
+const handleRequest = (req, res) => {
+  console.log({ file, function: 'handleRequest', url: req.url, session: req.session, user: req.user });
 
   const context = {};
 
   // counter in session for demo
   if (!req.session.counter) req.session.counter = 0;
   req.session.counter++;
 
-  const initialState = session.createInitialReduxState(req.session);
+  const initialState = session.createInitialReduxState(req.session, req.user);
   const store = createReduxStore(initialState);
 
   const appHtml = renderToString(
@@ -51,6 +52,16 @@ app.get('*', (req, res) => {
   } else {
     res.send(renderPage(appHtml, store.getState()));
   }
+};
+
+app.get('*', (req, res) => {
+  console.log({ file, function:'get *', url: req.url, session: req.session });
+
+  // Call userMiddleware here only rather than register it by app.use().
+  // It is to reduce uncessary user db call.
+  // Once a function is registered by app.use, it is called even for asset request.
+  userMiddleware(req)
+    .then(() => handleRequest(req, res));
 });
 
 app.post('/signin', (req, res) => {

server/libs/session.js

@@ -2,23 +2,25 @@ import { awsConfig } from '../../config';
 import connectDynamoDb from 'connect-dynamodb';
 import session from 'express-session';
 
-const createInitialReduxState = (session) => {
+const file = 'server/libs/session.js';
+
+const createInitialReduxState = (session, user) => {
   const state = {
     sessionCounter: {
       counter: session.counter,
     },
   };
 
-  if (session.uid && session.name && session.pictureUrl && session.fbToken) {
+  if (session.fbToken && user) {
     state.user = {
-      uid: session.uid,
-      name: session.name,
-      pictureUrl: session.pictureUrl,
+      uid: user.id,
+      name: user.name,
+      pictureUrl: user.pictureUrl,
       fbToken: session.fbToken,
     };
   }
 
-  console.log({ function: 'createInitialReduxState', state });
+  console.log({ file, function: 'createInitialReduxState', state });
 
   return state;
 };
@@ -57,15 +59,14 @@ const createSessionMiddleware = () => {
   return session(sessionOption);
 };
 
-const updateAuthResult = (req, authResponse) => {
-  req.session.uid = authResponse.uid;
-  req.session.name = authResponse.name;
-  req.session.pictureUrl = authResponse.pictureUrl;
-  req.session.fbToken = authResponse.fbToken;
+const update = (req, data) => {
+  console.log({ file, function: 'update', data });
+
+  req.session = Object.assign(req.session, data);
 };
 
 module.exports = {
   createInitialReduxState,
   createSessionMiddleware,
-  updateAuthResult,
+  update,
 };

server/libs/userDB.js

@@ -90,6 +90,20 @@ const findUserTable = (id) => new Promise((resolve, reject) => {
   });
 });
 
+const findUser = async (id) => {
+  try {
+    const user = await findUserTable(id);
+
+    console.log({ file, function: 'findUser', id, user });
+
+    return user;
+  } catch(err) {
+    console.error({ file, function: 'findUser', id, err });
+
+    return null;
+  }
+};
+
 const findUserByFbId = async (fbId) => {
   try {
     const fbIdUser = await findFbIdIndex(fbId);
@@ -108,14 +122,10 @@ const findUserByFbId = async (fbId) => {
   }
 };
 
-const updateUser = () => {
-
-};
-
 const userDB = {
   createUser,
+  findUser,
   findUserByFbId,
-  updateUser,
 };
 
 export default userDB;

server/libs/userMiddleware.js

@@ -0,0 +1,21 @@
+import userDB from './userDB';
+
+const file = 'server/libs/userMiddleware.js';
+
+export default async (req) => {
+  const uid = req.session.uid;
+
+  console.log({ file, function: 'default', url: req.url, uid });
+
+  if (!uid) return null;
+
+  try {
+    const user = await userDB.findUser(uid);
+    req.user = user;
+    console.log({ file, function: 'default', user });
+    return null;
+  } catch(err) {
+    console.error({ file, function: 'default', err });
+    return null;
+  }
+};