Do not build documentation in Circle CI, Read the Docs handles that 💯 (readthedocs#9788)

* Do not build documentation in Circle CI, Read the Docs handles that - warnings are now enabled

* Add comments to Tox environments that aren't run in CI

Author: benjaoming

.circleci/config.yml

@@ -47,8 +47,6 @@ jobs:
       - run: tox -e pre-commit
       - run: tox -e migrations
       - run: tox -e lint
-      - run: tox -e docs
-      - run: tox -e docs-dev
       - run: scripts/circle/install_node.sh
       - run:
           name: Add node to the path

.readthedocs.yml

@@ -4,6 +4,7 @@ formats: all
 
 sphinx:
   configuration: docs/conf.py
+  fail_on_warning: true
 
 python:
   install:

tox.ini

@@ -29,6 +29,7 @@ allowlist_externals =
     sh
     git
 
+# This is NOT run in CI builds, it can be used locally for convenience
 [testenv:docs]
 description = Build readthedocs user documentation
 changedir = {toxinidir}/docs
@@ -39,6 +40,7 @@ setenv =
 commands =
     sphinx-build -W --keep-going -b html -d {envtmpdir}/doctrees . {envtmpdir}/html
 
+# This is NOT run in CI builds, it can be used locally for convenience
 [testenv:docs-dev]
 description = Build readthedocs developer documentation
 changedir = {toxinidir}/docs