Skip to content

Commit 86772d3

Browse files
committed
Rename VALUE_IS_OWNED_RAW to VALUE_IS_RAW_STRING
1 parent a035116 commit 86772d3

File tree

7 files changed

+19
-19
lines changed

7 files changed

+19
-19
lines changed

extras/tests/JsonDocument/shrinkToFit.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ TEST_CASE("JsonDocument::shrinkToFit()") {
9797
<< AllocatorLog::Reallocate(4096, 0));
9898
}
9999

100-
SECTION("owned raw") {
101-
doc.set(serialized(std::string("[{},12]")));
100+
SECTION("raw string") {
101+
doc.set(serialized("[{},12]"));
102102

103103
doc.shrinkToFit();
104104

extras/tests/JsonVariant/memoryUsage.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ TEST_CASE("JsonVariant::memoryUsage()") {
3737
REQUIRE(var.memoryUsage() == doc.memoryUsage());
3838
}
3939

40-
SECTION("returns size of owned raw") {
41-
var.set(serialized(std::string("hello")));
40+
SECTION("returns size of raw string") {
41+
var.set(serialized("hello"));
4242
REQUIRE(var.memoryUsage() == sizeofString(5));
4343
REQUIRE(var.memoryUsage() == doc.memoryUsage());
4444
}

src/ArduinoJson/Variant/ConverterImpl.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ convertToJson(const T& src, JsonVariant dst) {
161161
template <typename T>
162162
struct Converter<SerializedValue<T>> : private detail::VariantAttorney {
163163
static void toJson(SerializedValue<T> src, JsonVariant dst) {
164-
variantSetOwnedRaw(getData(dst), src, getPool(dst));
164+
variantSetRawString(getData(dst), src, getPool(dst));
165165
}
166166
};
167167

src/ArduinoJson/Variant/VariantContent.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ enum {
1717

1818
OWNED_VALUE_BIT = 0x01,
1919
VALUE_IS_NULL = 0,
20-
VALUE_IS_OWNED_RAW = 0x03,
20+
VALUE_IS_RAW_STRING = 0x03,
2121
VALUE_IS_LINKED_STRING = 0x04,
2222
VALUE_IS_OWNED_STRING = 0x05,
2323

src/ArduinoJson/Variant/VariantData.hpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class VariantData {
4545
return visitor.visitString(content_.asString.data,
4646
content_.asString.size);
4747

48-
case VALUE_IS_OWNED_RAW:
48+
case VALUE_IS_RAW_STRING:
4949
return visitor.visitRawJson(content_.asString.data,
5050
content_.asString.size);
5151

@@ -70,7 +70,7 @@ class VariantData {
7070
T asFloat() const;
7171

7272
JsonString asString() const;
73-
JsonString asRaw() const;
73+
JsonString asRawString() const;
7474

7575
bool asBoolean() const;
7676

@@ -157,8 +157,8 @@ class VariantData {
157157
content_.asFloat = value;
158158
}
159159

160-
void setOwnedRaw(const char* data, size_t n) {
161-
setType(VALUE_IS_OWNED_RAW);
160+
void setRawString(const char* data, size_t n) {
161+
setType(VALUE_IS_RAW_STRING);
162162
content_.asString.data = data;
163163
content_.asString.size = n;
164164
}
@@ -204,7 +204,7 @@ class VariantData {
204204
size_t memoryUsage() const {
205205
switch (type()) {
206206
case VALUE_IS_OWNED_STRING:
207-
case VALUE_IS_OWNED_RAW:
207+
case VALUE_IS_RAW_STRING:
208208
return sizeofString(content_.asString.size);
209209
case VALUE_IS_OBJECT:
210210
case VALUE_IS_ARRAY:

src/ArduinoJson/Variant/VariantFunctions.hpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ inline bool variantCopyFrom(VariantData* dst, const VariantData* src,
6565
dst->setString(dup);
6666
return true;
6767
}
68-
case VALUE_IS_OWNED_RAW: {
69-
auto str = adaptString(src->asRaw());
68+
case VALUE_IS_RAW_STRING: {
69+
auto str = adaptString(src->asRawString());
7070
auto dup = storeString(pool, str, StringStoragePolicy::Copy());
7171
if (!dup)
7272
return false;
73-
dst->setOwnedRaw(dup.c_str(), str.size());
73+
dst->setRawString(dup.c_str(), str.size());
7474
return true;
7575
}
7676
default:
@@ -123,14 +123,14 @@ inline void variantSetString(VariantData* var, TAdaptedString value,
123123
}
124124

125125
template <typename T>
126-
inline void variantSetOwnedRaw(VariantData* var, SerializedValue<T> value,
127-
MemoryPool* pool) {
126+
inline void variantSetRawString(VariantData* var, SerializedValue<T> value,
127+
MemoryPool* pool) {
128128
if (!var)
129129
return;
130130
variantRelease(var, pool);
131131
const char* dup = pool->saveString(adaptString(value.data(), value.size()));
132132
if (dup)
133-
var->setOwnedRaw(dup, value.size());
133+
var->setRawString(dup, value.size());
134134
else
135135
var->setNull();
136136
}

src/ArduinoJson/Variant/VariantImpl.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ inline JsonString VariantData::asString() const {
8383
}
8484
}
8585

86-
inline JsonString VariantData::asRaw() const {
86+
inline JsonString VariantData::asRawString() const {
8787
switch (type()) {
88-
case VALUE_IS_OWNED_RAW:
88+
case VALUE_IS_RAW_STRING:
8989
return JsonString(content_.asString.data, content_.asString.size,
9090
JsonString::Copied);
9191
default:

0 commit comments

Comments
 (0)