JsonValidator: mark preloadJsonSchema as default (networknt#445)

JsonValidator#preloadJsonSchema is not required so there is no point in
forcing it to be implemented in each validator.

Co-authored-by: Daniil Nizovkin <[email protected]>

Author: DaNizz97

src/main/java/com/networknt/schema/BaseJsonValidator.java

@@ -161,11 +161,6 @@ public Set<ValidationMessage> walk(JsonNode node, JsonNode rootNode, String at,
         return validationMessages;
     }
 
-    @Override
-    public void preloadJsonSchema() {
-        // do nothing by default - to be overridden in subclasses
-    }
-
     protected void preloadJsonSchemas(final Collection<JsonSchema> schemas) {
         for (final JsonSchema schema: schemas) {
             schema.initializeValidators();

src/main/java/com/networknt/schema/JsonValidator.java

@@ -56,5 +56,7 @@ public interface JsonValidator extends JsonSchemaWalker {
      * are invalid (like <code>$ref</code> not resolving)
      * @since 1.0.54
      */
-    void preloadJsonSchema() throws JsonSchemaException;
+    default void preloadJsonSchema() throws JsonSchemaException {
+        // do nothing by default - to be overridden in subclasses
+    }
 }

src/main/java/com/networknt/schema/NonValidationKeyword.java

@@ -35,11 +35,6 @@ private Validator(String keyword) {
         public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String at) {
             return Collections.emptySet();
         }
-
-        @Override
-        public void preloadJsonSchema() {
-            // not used and the Validator is not extending from BaseJsonValidator
-        }
     }
 
     public NonValidationKeyword(String keyword) {

src/main/java/com/networknt/schema/PatternValidator.java

@@ -164,9 +164,4 @@ public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String
             return Collections.emptySet();
         }
     }
-
-    @Override
-    public void preloadJsonSchema() {
-        // not used and the validator does not inherit from BaseJsonValidator
-    }
 }

src/test/java/com/networknt/schema/CollectorContextTest.java

@@ -296,11 +296,6 @@ public Set<ValidationMessage> walk(JsonNode node, JsonNode rootNode, String at,
             // Ignore this method for testing.
             return null;
         }
-
-        @Override
-        public void preloadJsonSchema() {
-            // not used in testing
-        }
     }
 
     private class CustomCollector extends AbstractCollector<List<String>> {
@@ -378,11 +373,6 @@ public Set<ValidationMessage> walk(JsonNode node, JsonNode rootNode, String at,
             // Ignore this method for testing.
             return null;
         }
-
-        @Override
-        public void preloadJsonSchema() {
-            // not used in testing
-        }
     }
 
     private ValidationResult validate(String jsonData) throws JsonMappingException, JsonProcessingException, Exception {

src/test/java/com/networknt/schema/CustomMetaSchemaTest.java

@@ -66,11 +66,6 @@ public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String
                 String valueName = enumNames.get(idx);
                 return fail(CustomErrorMessageType.of("tests.example.enumNames", new MessageFormat("{0}: enumName is {1}")), at, valueName);
             }
-
-            @Override
-            public void preloadJsonSchema() {
-                // not used in testing
-            }
         }
 
 

src/test/java/com/networknt/schema/JsonWalkTest.java

@@ -164,11 +164,6 @@ public Set<ValidationMessage> walk(JsonNode node, JsonNode rootNode, String at,
                                                boolean shouldValidateSchema) {
                 return new LinkedHashSet<ValidationMessage>();
             }
-
-            @Override
-            public void preloadJsonSchema() {
-                // not used in testing
-            }
         }
     }