chore: Code cleanup

Author: barbeau

complete/src/main/java/com/example/android/whileinuselocation/ForegroundOnlyLocationService.kt

@@ -72,7 +72,7 @@ class ForegroundOnlyLocationService : LifecycleService() {
     lateinit var repository: LocationRepository
 
     // Get a reference to the Job from the Flow so we can stop it from UI events
-    private lateinit var locationFlow: Job
+    private var locationFlow: Job? = null
 
     override fun onCreate() {
         super.onCreate()
@@ -177,7 +177,7 @@ class ForegroundOnlyLocationService : LifecycleService() {
     fun unsubscribeToLocationUpdates() {
         Log.d(TAG, "unsubscribeToLocationUpdates()")
 
-        locationFlow.cancel()
+        locationFlow?.cancel()
         SharedPreferenceUtil.saveLocationTrackingPref(this, false)
     }
 

complete/src/main/java/com/example/android/whileinuselocation/MainActivity.kt

@@ -115,7 +115,7 @@ class MainActivity : AppCompatActivity(), SharedPreferences.OnSharedPreferenceCh
     lateinit var repository: LocationRepository
 
     // Get a reference to the Job from the Flow so we can stop it from UI events
-    private lateinit var locationFlow: Job
+    private var locationFlow: Job? = null
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -283,7 +283,7 @@ class MainActivity : AppCompatActivity(), SharedPreferences.OnSharedPreferenceCh
     }
 
     private fun unsubscribeToLocationUpdates() {
-        locationFlow.cancel()
+        locationFlow?.cancel()
         foregroundOnlyLocationService?.unsubscribeToLocationUpdates()
     }
 }

complete/src/main/java/com/example/android/whileinuselocation/data/SharedLocationManager.kt

@@ -28,7 +28,7 @@ class SharedLocationManager @Inject constructor(
 ) {
 
     private val _receivingLocationUpdates: MutableStateFlow<Boolean> =
-        MutableStateFlow<Boolean>(false)
+        MutableStateFlow(false)
 
     /**
      * Status of location updates, i.e., whether the app is actively subscribed to location changes.