Fix: Use TSAbsractMethodDefinition for abstract constructor (fixes eslint#228)

Author: azz

lib/ast-converter.js

@@ -116,6 +116,17 @@ function isAsyncFunction(node) {
     });
 }
 
+/**
+ * Returns true if the given TSNode has the AbstractKeyword modifier.
+ * @param  {TSNode} node TypeScript AST node
+ * @returns {boolean}    has abstract modifier
+ */
+function isAbstract(node) {
+    return !!node.modifiers && node.modifiers.some(function(modifier) {
+        return modifier.kind === ts.SyntaxKind.AbstractKeyword;
+    });
+}
+
 /**
  * Returns true if the given TSToken is a comma
  * @param  {TSToken}  token the TypeScript token
@@ -1164,10 +1175,7 @@ module.exports = function(ast, extra) {
                      */
                     var methodDefinitionType = "MethodDefinition";
                     if (node.modifiers && node.modifiers.length) {
-                        var isAbstractMethod = node.modifiers.some(function(modifier) {
-                            return modifier.kind === ts.SyntaxKind.AbstractKeyword;
-                        });
-                        if (isAbstractMethod) {
+                        if (isAbstract(node)) {
                             methodDefinitionType = "TSAbstractMethodDefinition";
                         }
                     }
@@ -1206,6 +1214,7 @@ module.exports = function(ast, extra) {
             case SyntaxKind.Constructor:
 
                 var constructorIsStatic = Boolean(ts.getModifierFlags(node) & ts.ModifierFlags.Static),
+                    constructorIsAbstract = isAbstract(node),
                     firstConstructorToken = constructorIsStatic ? ts.findNextToken(node.getFirstToken(), ast) : node.getFirstToken(),
                     constructorLoc = ast.getLineAndCharacterOfPosition(node.parameters.pos - 1),
                     constructor = {
@@ -1275,7 +1284,7 @@ module.exports = function(ast, extra) {
                 }
 
                 assign(result, {
-                    type: "MethodDefinition",
+                    type: constructorIsAbstract ? "TSAbstractMethodDefinition" : "MethodDefinition",
                     key: constructorKey,
                     value: constructor,
                     computed: constructorIsComputed,
@@ -1533,10 +1542,7 @@ module.exports = function(ast, extra) {
                      * TypeScript class declarations can be defined as "abstract"
                      */
                     if (node.kind === SyntaxKind.ClassDeclaration) {
-                        var isAbstractClass = node.modifiers.some(function(modifier) {
-                            return modifier.kind === ts.SyntaxKind.AbstractKeyword;
-                        });
-                        if (isAbstractClass) {
+                        if (isAbstract(node)) {
                             classNodeType = "TSAbstract" + classNodeType;
                         }
                     }