feat(visualqa): review comments implemented

Author: Dinesh Sajwan

lambda/aws-qa-appsync-opensearch/question_answering/src/qa_agent/chain.py

@@ -94,7 +94,8 @@ def run_question_answering(arguments):
             send_job_status(status_variables)
             return ''
 
-        model_max_tokens = get_max_tokens()
+        model_id=qa_model['modelId']
+        model_max_tokens = get_max_tokens(model_id)
         logger.info(
             f'For the current question, we have a max model length of {model_max_tokens} and a document containing {document_number_of_tokens} tokens')
 

lambda/aws-qa-appsync-opensearch/question_answering/src/qa_agent/helper.py

@@ -11,6 +11,7 @@
 # and limitations under the License.
 #
 import os
+import tempfile
 import boto3
 import json
 import base64
@@ -195,7 +196,7 @@ def get_presigned_url(bucket,key) -> str:
 
 def download_file(bucket,key )-> str:
         try: 
-            file_path = "/tmp/" + os.path.basename(key)
+            file_path = os.path.join(tempfile.gettempdir(), os.path.basename(image_file))
             s3.download_file(bucket, key,file_path)
             logger.info(f"file downloaded {file_path}")
             return file_path

lambda/aws-rag-appsync-stepfn-opensearch/embeddings_job/src/helpers/image_loader.py

@@ -12,6 +12,7 @@
 #
 
 import os
+import tempfile
 import time
 import base64
 import json
@@ -52,7 +53,7 @@ def __init__(self, bucket: str, image_file: str,image_detail_file: str,modelid:s
     def encode_image_to_base64(self,image_file_path,image_file) -> str:
         with open(image_file_path, "rb") as image_file:
             b64_image = base64.b64encode(image_file.read()).decode('utf8')
-            b64_image_path = os.path.join("/tmp/", f"{Path(image_file_path).stem}.b64")
+            b64_image_path = os.path.join(tempfile.gettempdir(), f"{Path(image_file_path).stem}.b64")
             with open(b64_image_path, "wb") as b64_image_file:
                 b64_image_file.write(bytes(b64_image, 'utf-8'))
         return b64_image_path
@@ -107,8 +108,8 @@ def get_presigned_url(self) -> str:
 
     @tracer.capture_method
     def download_file(self,key )-> str:
-        try: 
-            file_path = "/tmp/" + os.path.basename(key)
+        try:
+            file_path = os.path.join(tempfile.gettempdir(), os.path.basename(key)) 
             s3_client.download_file(self.bucket, key,file_path)
             print(f"file downloaded {file_path}")
             return file_path

lambda/aws-rag-appsync-stepfn-opensearch/s3_file_transformer/src/helpers/image_transformer.py

@@ -11,6 +11,7 @@
 # and limitations under the License.
 #
 import os
+import tempfile
 import boto3
 
 
@@ -104,9 +105,9 @@ def image_resize(self)-> str:
         Image.MAX_IMAGE_PIXELS = 100000000
         fileshort = os.path.basename(self.file_name)
 
-        print(f'fileshort {fileshort} ')
-        file_tmp = "/tmp/" + fileshort
-        
+
+        file_tmp = os.path.join(tempfile.gettempdir(), os.path.basename(self.file_name)) 
+
         with Image.open(file_tmp) as image:
                 image.verify()
         with Image.open(file_tmp) as image:  

lambda/aws-rag-appsync-stepfn-opensearch/s3_file_transformer/src/helpers/utils.py

@@ -12,6 +12,7 @@
 #
 
 import os
+import tempfile
 import boto3
 import json
 from botocore.exceptions import ClientError
@@ -128,7 +129,7 @@ def convert_lables_to_sentence(labels_str)-> str:
 
 def download_file(bucket, object )-> str:
         try: 
-            file_path = "/tmp/" + os.path.basename(object)
+            file_path = os.path.join(tempfile.gettempdir(), os.path.basename(object)) 
             s3.Bucket(bucket).download_file(object, file_path)
             return file_path
         except ClientError as client_err:
@@ -139,7 +140,7 @@ def download_file(bucket, object )-> str:
 
 def upload_file(bucket, file_name,key )-> str:
         try: 
-            file_path = "/tmp/" + os.path.basename(file_name)
+            file_path = os.path.join(tempfile.gettempdir(), os.path.basename(file_name)) 
             s3.meta.client.upload_file(file_path, bucket,key)
             return file_path
         except ClientError as client_err: