Skip to content
This repository was archived by the owner on Apr 5, 2025. It is now read-only.

feat(python)!: add v2 layer and drop python 3.6 support #4

Merged
merged 12 commits into from
Oct 3, 2022
Merged

feat(python)!: add v2 layer and drop python 3.6 support #4

merged 12 commits into from
Oct 3, 2022

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Sep 30, 2022 •
edited
Loading

This PR adds support for the Lambda Powertools Layer v2 for Python.

Plan for the cdk-powertools-layer construct

  • release a new major version 3.x of the construct
  • this will allow us to keep using the existing 2.x construct for powertools v1 (which we will have to maintain for a couple of months), while using the 3.x construct for powertools v2

Changes include:

  • remove python 3.6 support
  • aggregated all extra dependencies in "all" group
  • removed unnecessary files from Lambda Layer to reduce size
  • allow the option to publish layer into multiple architectures

Current layer sizes:

  • Uncompressed: 4.5MB
  • Compressed: 936KB

@rubenfonseca rubenfonseca marked this pull request as ready for review September 30, 2022 09:24
@rubenfonseca rubenfonseca requested a review from am29d September 30, 2022 09:24
@rubenfonseca rubenfonseca mentioned this pull request Sep 30, 2022
Merged
7 tasks
rubenfonseca
rubenfonseca commented Oct 3, 2022
View reviewed changes
heitorlessa
heitorlessa suggested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last notes as per peer reviewing session

@heitorlessa heitorlessa changed the title feat: add suport for python v2 layer feat(python): add suport for v2 layer and drop python 3.6 support Oct 3, 2022
@heitorlessa heitorlessa changed the title feat(python): add suport for v2 layer and drop python 3.6 support feat(python): add v2 layer and drop python 3.6 support Oct 3, 2022
rubenfonseca and others added 10 commits October 3, 2022 15:32
heitorlessa
heitorlessa suggested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny change to remove leftover dependencies from boto, and one nitpick ;-)

Good to merge after that

@heitorlessa heitorlessa mentioned this pull request Oct 3, 2022
Closed
2 tasks
heitorlessa
heitorlessa reviewed Oct 3, 2022
View reviewed changes
heitorlessa
heitorlessa approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work, thank you @rubenfonseca ! Can't wait for V2 this month

@rubenfonseca rubenfonseca changed the title feat(python): add v2 layer and drop python 3.6 support feat(python)!: add v2 layer and drop python 3.6 support Oct 3, 2022
@rubenfonseca rubenfonseca merged commit aca4b72 into aws-powertools:main Oct 3, 2022
@rubenfonseca rubenfonseca deleted the feat/python-v2 branch October 3, 2022 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

@am29d am29d Awaiting requested review from am29d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenfonseca @heitorlessa