Skip to content

S3EventRecord doesn't implement Default #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amir-haroun opened this issue Nov 10, 2023 · 3 comments
Closed

S3EventRecord doesn't implement Default #725

amir-haroun opened this issue Nov 10, 2023 · 3 comments

Comments

@amir-haroun
Copy link
Contributor

Hello,
I am trying to instanciate the S3EventRecord but it's impossible since it doesn't implement the Default trait.
https://github.com/awslabs/aws-lambda-rust-runtime/blob/8e6d77c5cfbbcacbc751758a8d2f1074538797ac/lambda-events/src/event/s3/event.rs#L16C24-L16C35
All other structs implement it, is there any reason to not implement it here?
@calavera
Copy link
Contributor

It was probably a miss. Feel free to open a PR with the implementation.

@amir-haroun
Copy link
Contributor Author

Done
#726

@amir-haroun amir-haroun mentioned this issue Nov 10, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for the maintainers of this repository to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calavera @amir-haroun