Skip to content

Commit ba920fb

Browse files
committed
Make less copies of extension services.
Signed-off-by: David Calavera <[email protected]>
1 parent dc3dfea commit ba920fb

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

lambda-extension/src/extension.rs

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,13 @@ where
241241
validate_buffering_configuration(self.log_buffering)?;
242242

243243
let addr = SocketAddr::from(([0, 0, 0, 0], self.log_port_number));
244+
let service = log_processor.make_service(());
245+
let service = Arc::new(Mutex::new(service.await.unwrap()));
244246
tokio::task::spawn(async move {
245247
trace!("Creating new logs processor Service");
246248

247249
loop {
248-
let service = log_processor.make_service(());
249-
let service = Arc::new(Mutex::new(service.await.unwrap()));
250+
let service: Arc<Mutex<_>> = service.clone();
250251
let make_service = service_fn(move |req: Request<Incoming>| log_wrapper(service.clone(), req));
251252

252253
let listener = TcpListener::bind(addr).await.unwrap();
@@ -285,23 +286,14 @@ where
285286

286287
validate_buffering_configuration(self.telemetry_buffering)?;
287288

288-
// Spawn task to run processor
289-
// let make_service = service_fn(move |_socket: &AddrStream| {
290-
// trace!("Creating new telemetry processor Service");
291-
// let service = telemetry_processor.make_service(());
292-
// async move {
293-
// let service = Arc::new(Mutex::new(service.await?));
294-
// Ok::<_, T::MakeError>(service_fn(move |req| telemetry_wrapper(service.clone(), req)))
295-
// }
296-
// });
297-
298289
let addr = SocketAddr::from(([0, 0, 0, 0], self.telemetry_port_number));
290+
let service = telemetry_processor.make_service(());
291+
let service = Arc::new(Mutex::new(service.await.unwrap()));
299292
tokio::task::spawn(async move {
300293
trace!("Creating new telemetry processor Service");
301294

302295
loop {
303-
let service = telemetry_processor.make_service(());
304-
let service = Arc::new(Mutex::new(service.await.unwrap()));
296+
let service = service.clone();
305297
let make_service = service_fn(move |req| telemetry_wrapper(service.clone(), req));
306298

307299
let listener = TcpListener::bind(addr).await.unwrap();

0 commit comments

Comments
 (0)