Skip to content

Bug (Tracer): Tracer imports all the components via TracerInterface #1068 #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rreddypally
Copy link

Description of your changes

Import TracerInterface only instead of all the modules from the root to avoid importing unused modules like middy

How to verify this change

Import Tracer as import { Tracer } from "@aws-lambda-powertools/tracer/lib/Tracer"; without middy node module and build should pass

Related issues, RFCs

Issue number: #1068

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added blocked This item's progress is blocked by external dependency or reason do-not-merge This item should not be merged labels Aug 22, 2022
@dreamorosi
Copy link
Contributor

Hi @rreddypally, thank you for opening the PR.

Before starting to review this I would like to understand better what's happening.

Let's have a discussion in #1068 and then after we have agreed on a solution come back to this.

@dreamorosi dreamorosi added the tracer This item relates to the Tracer Utility label Aug 22, 2022
Copy link
Contributor

@flochaz flochaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I would have assumed that all compiler would do the job to only import what is between brackets ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This item's progress is blocked by external dependency or reason do-not-merge This item should not be merged tracer This item relates to the Tracer Utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants