Feature request: rename raiseOnEmptyMetrics to throwOnEmptyMetrics #348
Labels
completed
This item is complete and has been merged/shipped
feature-request
This item refers to a feature request for an existing or new utility
good-first-issue
Something that is suitable for those who want to start contributing
metrics
This item relates to the Metrics Utility
Milestone
Description of the feature request
Currently the metrics Class has a class propriety
shouldRaiseOnEmptyMetrics
and middleware/decorator parameterraiseOnEmptyMetrics
that when set to true, will cause the library to throw an error when no metrics are created.As flagged by @dreamorosi in this PR,
throw
is a more intuitive and accurate way to describe the behaviour in the Node.js runtime.The name is currently ported as it is from the Python library.
Problem statement
Based on above, the name of the parameters can be confusing for developers using the Node.js runtime.
Summary of the feature
raise
tothrow
)Code examples
Benefits for you and the wider AWS community
Better clarity of the feature, less confusion.
Describe alternatives you've considered
N/A
Additional context
Related issues, RFCs
The text was updated successfully, but these errors were encountered: