feat(middleware_factory): support router #954
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#953
Description of changes:
The changes needed for
lambda_handler_decorator
to support routers are only to modify the arguments of the inner wrapper and its invocation, so I modified it to accept arbitrary arguments.Due to the difference in signature (and function name), it may be preferable to instead move this to a clone named
router_decorator
instead of modifying the originallambda_handler_decorator
. If you would like me to do so, let me know and I can make the change.Checklist
Breaking change checklist
There may be potential issues with positional arguments if we reuse the same decorator.
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.