Skip to content

fix(tracer): add warm start annotation (ColdStart=False) #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available: #850

Description of changes:

Before this feature, you'd only filter traces for cold start invocations.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2021
@heitorlessa heitorlessa added the feature New feature or functionality label Nov 29, 2021
@heitorlessa
Copy link
Contributor Author

cc @pankajagrawal16 @t1agob

@heitorlessa heitorlessa changed the title feat(tracer): add warm start annotation fix(tracer): add warm start annotation (ColdStart=False) Nov 30, 2021
@heitorlessa heitorlessa added bug Something isn't working and removed feature New feature or functionality labels Nov 30, 2021
@heitorlessa
Copy link
Contributor Author

Changing to bugfix as Java and C# has it

@heitorlessa heitorlessa merged commit c1eb928 into aws-powertools:develop Nov 30, 2021
@heitorlessa heitorlessa deleted the feat/tracer-non-sparse-coldstart-annotation branch November 30, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants