Skip to content

docs: updated Lambda Layers definition & limitations. #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

eldritchideen
Copy link
Contributor

@eldritchideen eldritchideen commented Oct 23, 2021

Issue #, if available:
#750

Description of changes:

Updated the info around the usage of Lambda Layers, described Lambda Layers, linked to documentation on how to add a layer via the console. Also noted that only zip archive based functions can use layers.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/index.md

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2021
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #775 (0cc4f6b) into develop (7a7ba0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #775   +/-   ##
========================================
  Coverage    99.97%   99.97%           
========================================
  Files          116      116           
  Lines         4939     4939           
  Branches       275      275           
========================================
  Hits          4938     4938           
  Partials         1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7ba0a...0cc4f6b. Read the comment docs.

@heitorlessa
Copy link
Contributor

Also noted that only zip archive based functions can use layers.

That's indeed a great call out. Using Lambda Layers with OCI wouldn't be necessary if supported, but inline functions are common for CloudFormation Custom Resources.

Looking into it today as I'll make minor adjustments to wording.

Thank you!

@heitorlessa heitorlessa self-assigned this Oct 29, 2021
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
@heitorlessa
Copy link
Contributor

Made some copywriting changes, made the .zip vs inline vs OCI more explicit with a warning, bundled Pydantic warning together with Lambda inline/OCI info, and fixed two indentation issues when copying SAM and Serverless Framework to the clipboard.

Merging now ;)

Thanks a lot again @eldritchideen

@heitorlessa heitorlessa changed the title docs: Updated Lambda Layers description. docs: updated Lambda Layers definition & limitations. Oct 29, 2021
@heitorlessa heitorlessa merged commit 750f482 into aws-powertools:develop Oct 29, 2021

!!! warning "Limitations"

Container Image deployment (OCI) or inline Lambda functions do not support Lambda Layers.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found you can't use the Lambda layer if you want to use Lambda code signing. Not sure if we want to call that out since it applies to all Lambda Layers, not just power tools.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jplock may i suggest you open an issue so this note doesn't get lost ?

@heitorlessa
Copy link
Contributor

heitorlessa commented Oct 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants