-
Notifications
You must be signed in to change notification settings - Fork 421
docs: updated Lambda Layers definition & limitations. #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated Lambda Layers definition & limitations. #775
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #775 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 116 116
Lines 4939 4939
Branches 275 275
========================================
Hits 4938 4938
Partials 1 1 Continue to review full report at Codecov.
|
That's indeed a great call out. Using Lambda Layers with OCI wouldn't be necessary if supported, but inline functions are common for CloudFormation Custom Resources. Looking into it today as I'll make minor adjustments to wording. Thank you! |
Made some copywriting changes, made the .zip vs inline vs OCI more explicit with a warning, bundled Merging now ;) Thanks a lot again @eldritchideen |
|
||
!!! warning "Limitations" | ||
|
||
Container Image deployment (OCI) or inline Lambda functions do not support Lambda Layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found you can't use the Lambda layer if you want to use Lambda code signing. Not sure if we want to call that out since it applies to all Lambda Layers, not just power tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jplock may i suggest you open an issue so this note doesn't get lost ?
I’m on the fence on that one - it’s hard to find balance on how much we
need to tell customers what’s already on Lambda docs.
I’m gonna make a release in a few hours. If either you or Dani feel
strongly about it I’m happy to do it
…On Fri, 29 Oct 2021 at 17:10, Dani Comnea ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/index.md
<#775 (comment)>
:
> @@ -150,27 +167,17 @@ Include Lambda Powertools in your function using the [AWS Lambda Console](https:
? Do you want to edit the local lambda function now? No
```
-??? note "Expand to copy any regional Lambda Layer ARN"
+=== "Get the Layer .zip contents"
+ Change {region} to your AWS region, e.g. `eu-west-1`
+
+ **`aws lambda get-layer-version-by-arn --arn arn:aws:lambda:{region}:017000801446:layer:AWSLambdaPowertoolsPython:3 --region {region}`**
+
+!!! warning "Limitations"
+
+ Container Image deployment (OCI) or inline Lambda functions do not support Lambda Layers.
@jplock <https://github.com/jplock> may i suggest you open an issue so
this note doesn't get lost ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBCK5VUMYEO5WNF5YHDUJLBPRANCNFSM5GR4VPDA>
.
|
Issue #, if available:
#750
Description of changes:
Updated the info around the usage of Lambda Layers, described Lambda Layers, linked to documentation on how to add a layer via the console. Also noted that only zip archive based functions can use layers.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/index.md