Skip to content

fix(api-gateway): strip stage name from request path #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Aug 19, 2021

Issue #, if available:

Description of changes:

Automatically strip out "/" + stage when building the request path.

Checklist

Breaking change checklist

This is potentially a break change, if mapping against the stage name

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2021
@heitorlessa heitorlessa added bug Something isn't working area/event_handlers and removed area/utilities labels Aug 19, 2021
@heitorlessa heitorlessa added this to the 1.20.0 milestone Aug 19, 2021
@heitorlessa heitorlessa self-assigned this Aug 19, 2021
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice and clean! There's a merge conflict, lemme know when it's resolved and I'll merge right away

NOTE: Don't use github ui for merge conflicts
@heitorlessa heitorlessa merged commit b2773d5 into aws-powertools:develop Aug 19, 2021
@michaelbrewer michaelbrewer deleted the fix/http-api-path branch August 19, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants