-
Notifications
You must be signed in to change notification settings - Fork 421
fix: remove unnecessary typing-extensions for py3.8 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary typing-extensions for py3.8 #281
Conversation
c1e7324
to
fc78bea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
- Coverage 99.75% 99.68% -0.07%
===========================================
Files 79 79
Lines 2839 2861 +22
Branches 118 120 +2
===========================================
+ Hits 2832 2852 +20
- Misses 5 7 +2
Partials 2 2
Continue to review full report at Codecov.
|
fc78bea
to
f584ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, great to keep the package size down where we can! Added a small suggestion to change - otherwise LGTM!
f584ed4
to
11627ff
Compare
Thanks a lot for this contribution @nadobando !!! And thanks @cakepietoast for the review. Merging this and publishing a new release |
* develop: chore: bump to 1.10.2 (aws-powertools#282) fix: batch processing exceptions (aws-powertools#276)
Issue #280
Description of changes:
Added if block to know if typing_extensions should be imported based on the python version.
if python >= 3.8 typing extensions will not be imported and the native implementation will be used
else will try to import typing_extensions and catch the ImportError
Updated modules which imported this dependency.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.