-
Notifications
You must be signed in to change notification settings - Fork 421
fix(parameters): AppConfigProvider when retrieving multiple unique configuration names #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
heitorlessa
merged 3 commits into
aws-powertools:develop
from
leandrodamascena:parameters/appconfig
Jun 5, 2023
Merged
fix(parameters): AppConfigProvider when retrieving multiple unique configuration names #2378
heitorlessa
merged 3 commits into
aws-powertools:develop
from
leandrodamascena:parameters/appconfig
Jun 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heitorlessa
reviewed
Jun 5, 2023
heitorlessa
reviewed
Jun 5, 2023
heitorlessa
reviewed
Jun 5, 2023
Signed-off-by: Heitor Lessa <[email protected]>
heitorlessa
approved these changes
Jun 5, 2023
roger-zhangg
pushed a commit
to roger-zhangg/aws-lambda-powertools-python
that referenced
this pull request
Jun 5, 2023
…nfiguration names (aws-powertools#2378) Co-authored-by: heitorlessa <[email protected]>
sthulb
pushed a commit
that referenced
this pull request
Jun 19, 2023
…nfiguration names (#2378) Co-authored-by: heitorlessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2362
Summary
Changes
This RP aims to fix the issue with the AppConfig parameter provider retrieving different parameters in the same Lambda execution. The way it is implemented,
self._next_token
caches token globally and retrieves only the value of the first call, and discards the others.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.