fix(shared): skip user agent on much older botocore versions #2366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenfonseca
requested review from
leandrodamascena
and removed request for
a team
pull-request-size
bot
added
the
size/XS
heitorlessa
approved these changes
Jun 2, 2023
heitorlessa
changed the title
roger-zhangg
pushed a commit
to roger-zhangg/aws-lambda-powertools-python
that referenced
this pull request
Jun 5, 2023
…ertools#2366) fix: don't crash on old botocore versions
sthulb
pushed a commit
that referenced
this pull request
Jun 19, 2023
fix: don't crash on old botocore versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2365
Summary
Changes
With this change, we will not crash when the botocore version is old.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.