Skip to content

feat: Add alb lambda event support to Parser utility #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

ran-isenberg
Copy link
Contributor

feat: Add alb lambda event support to Parser utility #228

@heitorlessa heitorlessa added area/utilities feature New feature or functionality labels Dec 1, 2020
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Two questions:

  1. Could you update the docs too?
  2. Do we need an envelope for the body field?

Here's the line where we tell customers what models Parser offers: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#extending-built-in-models

@heitorlessa heitorlessa self-assigned this Dec 1, 2020
@ran-isenberg
Copy link
Contributor Author

Looks great!! Two questions:

  1. Could you update the docs too?
  2. Do we need an envelope for the body field?

Here's the line where we tell customers what models Parser offers: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#extending-built-in-models

I didnt add the body parsing because i suppose in most cases you might want to use also the other params in the model so using an envelope would not be helpful.

@heitorlessa
Copy link
Contributor

thanks a lot as always @risenberg-cyberark - As discussed, I'll commit these suggestions, and will try pushing the docs to your branch then merge. Failing that, I'll merge as-is, then send another PR with docs and suggestions implemented ;)

ETA: This Friday EOD

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc added - Merging

@heitorlessa heitorlessa merged commit 415bfc6 into aws-powertools:develop Dec 4, 2020
@ran-isenberg ran-isenberg deleted the alb branch May 10, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants