feat(ci): dispatch GitHub analytics action #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenfonseca
requested review from
leandrodamascena
and removed request for
a team
boring-cyborg
bot
added
github-actions
pull-request-size
bot
added
the
size/M
2 tasks
rubenfonseca
force-pushed
the
rf/analytics-dispatch
branch
from
f174581 to
aa3f4a4
Compare
heitorlessa
suggested changes
Apr 24, 2023
| repository-projects: read | ||
| security-events: read | ||
| statuses: read | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Can we run in an environment do secrets are encrypted from forks?
You never know if we ever accidentally make a mistake in the IAM OIDC and allow any repo. This will prevent this attack vector.
There was a problem hiding this comment.
Done, created a new "analytics" environment and moved the secrets there. I've removed the old secrets too.
There was a problem hiding this comment.
Please note that the IAM OIDC would not be assumable since there's a condition to only be assumable by this repository too. In any case, it's better this way.
heitorlessa
approved these changes
Apr 24, 2023
|
Hey folks, do we need something like this in the TS repo? |
|
@dreamorosi yes Andrea, I will send instructions and open PR for the rest of the runtimes during the day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2160
Summary
Changes
This PR adds a new GitHub action that runs every hour. The action assumes an OIDC role and calls a Lambda Function that dispatches all the crawling functions synchronously.
User experience
After this change, we should see fresh analytics every hour.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.