fix(batch): resolve use of ValidationError in batch #2157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2156
Summary
Remove ValidationError import to remove implicit pydantic dependency
Changes
Removed use of "ValidationError" class in batch.py. Replaced instead with slightly nastier string class name comparison to detect the ValidationError. Intention of code remain in tact in that the ValidationError will be correctly handled when pydantic model validation fails.
User experience
Before:
[ERROR] Runtime.ImportModuleError: Unable to import module 'app': No module named 'pydantic'
After:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No not a breaking change - reversibng a breaking changeRFC issue number: Nil
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.