Skip to content

chore(batch): safeguard custom use of BatchProcessingError exception #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1203

Summary

Changes

Please provide a summary of what's being changed

Default list arg to empty list if None. This will safe guard for any undocumented use of BatchProcessingError within Batch utility.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner April 21, 2023 11:37
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team April 21, 2023 11:37
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2023
@github-actions github-actions bot added the internal Maintenance changes label Apr 21, 2023
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for rubenfonseca April 21, 2023 11:44
@@ -9,10 +11,10 @@


class BaseBatchProcessingError(Exception):
def __init__(self, msg="", child_exceptions: Optional[List[ExceptionInfo]] = None):
def __init__(self, msg="", child_exceptions: List[ExceptionInfo] | None = None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to use new annotations :)

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandrodamascena leandrodamascena merged commit d00425f into aws-powertools:develop Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: BaseBatchProcessingError.child_exceptions doesn't handle None case
2 participants