feat(runtime): add support for python 3.10 #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
dependencies
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/M
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2137 +/- ##
========================================
Coverage 97.48% 97.48%
========================================
Files 147 147
Lines 6835 6836 +1
Branches 483 497 +14
========================================
+ Hits 6663 6664 +1
Misses 136 136
Partials 36 36 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rubenfonseca
commented
Apr 18, 2023
tests/performance/test_metrics.py
Outdated
| METRICS_VALIDATION_SLA: float = 0.002 | ||
| METRICS_SERIALIZATION_SLA: float = 0.002 | ||
| METRICS_VALIDATION_SLA: float = 0.003 | ||
| METRICS_SERIALIZATION_SLA: float = 0.003 |
There was a problem hiding this comment.
Once I added python 3.10 the performance got slightly worse :(
There was a problem hiding this comment.
Ruben, I reverted this change. Looks like it was a one-time glitch.
rubenfonseca
requested review from
leandrodamascena
and removed request for
a team
2 tasks
leandrodamascena
changed the title
leandrodamascena
approved these changes
Apr 18, 2023
tests/performance/test_metrics.py
Outdated
| METRICS_VALIDATION_SLA: float = 0.002 | ||
| METRICS_SERIALIZATION_SLA: float = 0.002 | ||
| METRICS_VALIDATION_SLA: float = 0.003 | ||
| METRICS_SERIALIZATION_SLA: float = 0.003 |
There was a problem hiding this comment.
Ruben, I reverted this change. Looks like it was a one-time glitch.
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2136
Summary
Changes
This PR makes the necessary changes to support the new Python 3.10 runtime.
User experience
After this change, our project will be tested againt Python 3.10, including the E2E tests.
With this PR we also fix a problem with the current E2E tests that were running pn Python 3.9 only.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.