Skip to content

feat: include new EventBridge replay-name field in parser and data_classes utilities #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available:

Description of changes:

New EventBridge Replay feature introduces a new optional field replay-name: https://aws.amazon.com/blogs/aws/new-archive-and-replay-events-with-amazon-eventbridge/

This PR adds support for it in both data_classes and parser as replay_name.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #211 (62e64bf) into develop (f7bb809) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #211   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           69       69           
  Lines         2543     2547    +4     
  Branches       109      109           
========================================
+ Hits          2540     2544    +4     
  Misses           3        3           
Impacted Files Coverage Δ
...tools/utilities/data_classes/event_bridge_event.py 100.00% <100.00%> (ø)
...powertools/utilities/parser/models/event_bridge.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bb809...62e64bf. Read the comment docs.

Copy link
Contributor

@to-mc to-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heitorlessa heitorlessa merged commit 2b332dc into aws-powertools:develop Nov 20, 2020
@heitorlessa heitorlessa deleted the feat/eventbridge-replay-support branch November 20, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants