-
Notifications
You must be signed in to change notification settings - Fork 421
docs(idempotency): new sequence diagrams, fix idempotency record vs DynamoDB TTL confusion #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(idempotency): new sequence diagrams, fix idempotency record vs DynamoDB TTL confusion #2074
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
@awslabs/aws-lambda-powertools-typescript @awslabs/aws-lambda-powertools-java major improvement you can copy/paste to Idempotency docs once @leandrodamascena reviews it. |
Starting the review. |
fixing PR title shortly.. picked up my last commit somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added some comments, but it's a huge improvement to this documentation!
Really good job Heitor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Issue number: #2023
Summary
Improves Idempotency documentation after discussion with @pmarko1711 on Idempotency Record expiration vs DynamoDB TTL expiration.
As I improved it, I've noticed we were light on sequence diagrams to explain common scenarios Idempotency handles it (we can add more later).
Changes
idempotency record
terminology along with a diagram to explain what's in it (missed that when explaining to Peter how it looks like)Unrelated but sorely needed changes after
Choosing a payload subset for idempotency
, improved payment scenario by using composite idempotency hash with JMESPath. It's way more realistic and less error-prone to HTTP header change for example.User experience
New and revamped sequence diagrams depicting Idempotency Record Status too
New Idempotency Record terminology
Address confusion between Idempotency Record expiration vs DynamoDB time-to-live (TTL)
Adding screenshots shortly
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.