fix(feature_flags): make test conditions deterministic #2059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2058
Summary
Feature Flags
match
type test cases must have the non-expected value as default and the conditionwhen_match
must be equal toexpected_value
For the list of test cases below, the
expected_value
is assigned as thedefault
value which is returned when the condition does not match. The test only passes because both the expected and non-expected values are the same -True
meaning that the test cannot fail ever.Changes
For
match
cases - expected_value, is assigned to thewhen_match
of condition rather thandefault
anddefault
must returnFalse
Changed a similar flaw in the test case mentioned in documentation
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.