-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_sources): support for S3 Event Notifications through EventBridge #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_sources): support for S3 Event Notifications through EventBridge #2024
Conversation
Looking |
f227cc6
to
83e4d58
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2024 +/- ##
===========================================
+ Coverage 97.44% 97.46% +0.01%
===========================================
Files 146 146
Lines 6660 6749 +89
Branches 478 478
===========================================
+ Hits 6490 6578 +88
- Misses 134 135 +1
Partials 36 36
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding PR @ivica-k - I liked the attention to traceable testing errors via ids
in parametrized tests, and the use of .get()
in assertion to make parametrized possible.
THANK YOU!
Issue number:
#1656
Summary
Changes
adds dataclasses/events support for S3 event notifications through EventBridge
Note: Pay special attention to me overriding
mypy
checks with# type: ignore[override]
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.