feat(event_sources): support for custom properties in ActiveMQEvent

[alexaiss]

Summary

Changes

Adds custom properties to ActiveMQ event after Lambda Event Source Mappings added the support

User experience

Users will now be able to interpret custom properties at runtime for their ActiveMQ messages delivered via Lambda Event Source Mappings.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

[github-actions]

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

[rubenfonseca]

Hi @alexaiss thank you for your PR!

In order for us to handle it, you'll need to create an issue first. Please check the CONTRIBUTING guide for more details.

Can you please create an issue about this feature?

[heitorlessa]

I created an issue #2018 but I couldn't trace the origin though - when custom properties were added, or was it always there and we missed it?

Went down the rabbit hole reading every release note until November 2022 and couldn't find it either. However, Lambda MQ docs do have the properties key, Lambda Java Events merged @alexaiss PR too so they must be familiar, so going ahead with this PR.

[heitorlessa]

We don't have permissions to push to your fork, so please apply this patch so tests can pass and we can merge. We'll make a release tomorrow, hopefully this can be fixed earlier to be included.

Thank you!

---

From ee9343e814853d41b5f66057575946a221052cff Mon Sep 17 00:00:00 2001
From: heitorlessa <[email protected]>
Date: Thu, 16 Mar 2023 12:47:29 +0100
Subject: [PATCH] fix(tests): add custom properties

---
 tests/events/activeMQEvent.json | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/events/activeMQEvent.json b/tests/events/activeMQEvent.json
index 57d206ba..6bcae212 100644
--- a/tests/events/activeMQEvent.json
+++ b/tests/events/activeMQEvent.json
@@ -13,7 +13,10 @@
       },
       "timestamp": 1598827811958,
       "brokerInTime": 1598827811958,
-      "brokerOutTime": 1598827811959
+      "brokerOutTime": 1598827811959,
+      "properties": {
+        "testKey": "testValue"
+      }
     },
     {
       "messageID": "ID:b-9bcfa592-423a-4942-879d-eb284b418fc8-1.mq.us-west-2.amazonaws.com-37557-1234520418293-4:1:1:1:1",
@@ -30,7 +33,6 @@
       "properties": {
         "testKey": "testValue"
       }
-
     },
     {
       "messageID": "ID:b-9bcfa592-423a-4942-879d-eb284b418fc8-1.mq.us-west-2.amazonaws.com-37557-1234520418293-4:1:1:1:1",
@@ -49,4 +51,4 @@
       }
     }
   ]
-}
+}
\ No newline at end of file
-- 
2.37.1 (Apple Git-137.1)

[alexaiss]

Hi Heitor and Ruben,

Thanks for the comments. Apologies for missing creating an issue, thanks for doing that for me! And thanks for finding the bug, not sure how I missed that but it is fixed now to my knowledge.

I'm from one of the Lambda teams that maintains ActiveMQ Lambda integration, we recently added this as a minor improvement, not a feature launch. Thanks!

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (21a7400) 97.44% compared to head (d25a3ba) 97.45%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1999      +/-   ##
===========================================
+ Coverage    97.44%   97.45%   +0.01%     
===========================================
  Files          146      146              
  Lines         6660     6688      +28     
  Branches       478      478              
===========================================
+ Hits          6490     6518      +28     
  Misses         134      134              
  Partials        36       36              

Impacted Files	Coverage Δ
...wertools/utilities/data_classes/active_mq_event.py	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rubenfonseca]

Looking at this now

[rubenfonseca]

Thank you for the background, and for submitting this fix! Looking forward to release this later today.

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!