-
Notifications
You must be signed in to change notification settings - Fork 421
docs(homepage): Replace poetry command to add group parameter #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Poetry changed and deprecated the `--dev` subcommand to define dev dependencies. Now, they recommend using: ``` poetry add <deps_name> --group <group_name> ``` Signed-off-by: Marc Ramirez Invernon <[email protected]>
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hi @marcraminv! Thank you for submitting this PR. I added the "need-issue" and "do-not-merge" labels because according to our contribution guide, all PRs should have an issue to keep the tracker and governance in good shape. Would you mind opening an issue? I can review this PR tomorrow. Thank you. |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
dev
depsdev
deps
Hello @marcraminv! We are releasing a new version now and I opened the issue. Thank you so much for this improvement. We strive to have good documentation because you know how important this is to our customers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev
deps
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Hey @leandrodamascena ! Thanks for merging, and sorry being late replying the thread. Next time I will open the ticket first 👍 😃 |
No problem @marcraminv! I'm glad you could contribute to this release! :) |
Issue number: #1920
Summary
Changes
Poetry changed and deprecated the
--dev
subcommand to define dev dependencies.Now, they recommend using:
User experience
Before:
after
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.